Conversation
bkchr
reviewed
Sep 14, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
bkchr
reviewed
Sep 16, 2021
No way to have two instances of Ss58AddressFormat that mean the same thing but are different. (Before Custom(42) was the same as Ss58AddressFormat::Substrate but not eq.)
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
bkchr
reviewed
Sep 27, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
(brought in from master merge on substrate PR)
bkchr
reviewed
Sep 28, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
bkchr
approved these changes
Sep 29, 2021
Member
bkchr
left a comment
There was a problem hiding this comment.
Looks good.
Just some tests would be nice.
Member
Modulo the nitpicks. |
This was referenced Sep 29, 2021
bkchr
reviewed
Sep 30, 2021
build.rs
Outdated
| let mut registry = registry.registry; | ||
|
|
||
| let mut ordered_prefixes = registry.iter().map(|i| i.prefix).collect::<Vec<_>>(); | ||
| ordered_prefixes.sort_unstable(); |
Contributor
Author
There was a problem hiding this comment.
It's sorting primitives - there's no difference between 6 and 6 in this case - it's just a tad faster. In general I agree we don't want non-determinism but here I believe it makes no difference which we use.
Member
There was a problem hiding this comment.
Please use sort().
it's just a tad faster.
We are sorting here like in maximum 256 elements, no one will be able to tell the difference.
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less exceptions:
(See also paritytech/substrate#9755 )