Grandpa warp sync by expenses · Pull Request #294 · paritytech/smoldot

expenses · 2020-12-10T14:33:35Z

Messy first draft of grandpa warp sync networking and verification code.

expenses · 2020-12-10T15:03:37Z

At the moment the code seems to switch between successfully verifying a justification and not:

0: Ok(())
1: Err(NotAuthority([57, 25, 19, 43, 133, 30, 240, 253, 45, 174, 66, 167, 231, 52, 254, 84, 122, 245, 166, 184, 9, 0, 97, 0, 244, 137, 68, 215, 250, 232, 232, 239]))
2: Ok(())
3: Err(NotAuthority([86, 51, 183, 11, 128, 166, 200, 187, 22, 39, 15, 130, 204, 166, 213, 107, 39, 237, 123, 118, 200, 253, 90, 242, 152, 106, 37, 164, 120, 140, 228, 64]))
4: Ok(())
5: Err(NotAuthority([86, 51, 183, 11, 128, 166, 200, 187, 22, 39, 15, 130, 204, 166, 213, 107, 39, 237, 123, 118, 200, 253, 90, 242, 152, 106, 37, 164, 120, 140, 228, 64]))
6: Err(NotAuthority([155, 236, 173, 3, 230, 220, 172, 3, 206, 224, 126, 222, 188, 165, 71, 83, 20, 134, 20, 146, 205, 252, 150, 162, 20, 74, 103, 187, 233, 105, 147, 50]))
7: Ok(())
8: Ok(())
9: Err(NotAuthority([155, 236, 173, 3, 230, 220, 172, 3, 206, 224, 126, 222, 188, 165, 71, 83, 20, 134, 20, 146, 205, 252, 150, 162, 20, 74, 103, 187, 233, 105, 147, 50]))
10: Ok(())
11: Ok(())
12: Err(NotAuthority([57, 25, 19, 43, 133, 30, 240, 253, 45, 174, 66, 167, 231, 52, 254, 84, 122, 245, 166, 184, 9, 0, 97, 0, 244, 137, 68, 215, 250, 232, 232, 239]))
13: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
14: Err(NotAuthority([86, 51, 183, 11, 128, 166, 200, 187, 22, 39, 15, 130, 204, 166, 213, 107, 39, 237, 123, 118, 200, 253, 90, 242, 152, 106, 37, 164, 120, 140, 228, 64]))
15: Ok(())
16: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
17: Err(NotAuthority([86, 51, 183, 11, 128, 166, 200, 187, 22, 39, 15, 130, 204, 166, 213, 107, 39, 237, 123, 118, 200, 253, 90, 242, 152, 106, 37, 164, 120, 140, 228, 64]))
18: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
19: Err(NotAuthority([155, 236, 173, 3, 230, 220, 172, 3, 206, 224, 126, 222, 188, 165, 71, 83, 20, 134, 20, 146, 205, 252, 150, 162, 20, 74, 103, 187, 233, 105, 147, 50]))
20: Ok(())
21: Err(NotAuthority([86, 51, 183, 11, 128, 166, 200, 187, 22, 39, 15, 130, 204, 166, 213, 107, 39, 237, 123, 118, 200, 253, 90, 242, 152, 106, 37, 164, 120, 140, 228, 64]))
22: Err(NotAuthority([57, 25, 19, 43, 133, 30, 240, 253, 45, 174, 66, 167, 231, 52, 254, 84, 122, 245, 166, 184, 9, 0, 97, 0, 244, 137, 68, 215, 250, 232, 232, 239]))
23: Ok(())
24: Ok(())
25: Err(NotAuthority([155, 236, 173, 3, 230, 220, 172, 3, 206, 224, 126, 222, 188, 165, 71, 83, 20, 134, 20, 146, 205, 252, 150, 162, 20, 74, 103, 187, 233, 105, 147, 50]))
26: Ok(())
27: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
28: Ok(())
29: Ok(())
30: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
31: Err(NotAuthority([57, 25, 19, 43, 133, 30, 240, 253, 45, 174, 66, 167, 231, 52, 254, 84, 122, 245, 166, 184, 9, 0, 97, 0, 244, 137, 68, 215, 250, 232, 232, 239]))
32: Err(NotAuthority([86, 51, 183, 11, 128, 166, 200, 187, 22, 39, 15, 130, 204, 166, 213, 107, 39, 237, 123, 118, 200, 253, 90, 242, 152, 106, 37, 164, 120, 140, 228, 64]))
33: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
34: Ok(())
35: Ok(())
36: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
37: Ok(())
38: Ok(())
39: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
40: Err(NotAuthority([57, 25, 19, 43, 133, 30, 240, 253, 45, 174, 66, 167, 231, 52, 254, 84, 122, 245, 166, 184, 9, 0, 97, 0, 244, 137, 68, 215, 250, 232, 232, 239]))
41: Ok(())
42: Ok(())
43: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
44: Ok(())
45: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
46: Err(NotAuthority([86, 51, 183, 11, 128, 166, 200, 187, 22, 39, 15, 130, 204, 166, 213, 107, 39, 237, 123, 118, 200, 253, 90, 242, 152, 106, 37, 164, 120, 140, 228, 64]))
47: Ok(())
48: Err(NotAuthority([155, 236, 173, 3, 230, 220, 172, 3, 206, 224, 126, 222, 188, 165, 71, 83, 20, 134, 20, 146, 205, 252, 150, 162, 20, 74, 103, 187, 233, 105, 147, 50]))
49: Err(NotAuthority([121, 50, 207, 244, 49, 231, 72, 137, 47, 164, 142, 16, 198, 60, 23, 211, 15, 128, 202, 66, 228, 222, 57, 33, 230, 65, 36, 156, 215, 250, 60, 47]))
50: Err(NotAuthority([86, 51, 183, 11, 128, 166, 200, 187, 22, 39, 15, 130, 204, 166, 213, 107, 39, 237, 123, 118, 200, 253, 90, 242, 152, 106, 37, 164, 120, 140, 228, 64]))

Not sure what's going on here.

bin/full-node/src/network_service.rs

src/finality/grandpa/warp_sync.rs

src/network/service.rs

src/finality/justification/decode.rs

src/network/service.rs

src/finality/grandpa/warp_sync.rs

bin/full-node

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>

src/finality/grandpa/warp_sync.rs

src/network/service.rs

Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.26 to 0.3.27. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.26...0.3.27) --- updated-dependencies: - dependency-name: futures dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Start on grandpa warp sync

22fc179

expenses mentioned this pull request Dec 10, 2020

Grandpa warp sync request-response protocol paritytech/substrate#7711

Merged

expenses added 2 commits December 10, 2020 16:17

Allow turning Justifications into JustificationRefs

b059b7e

Change full-node code to attempt to verify justifications

5007b44

tomaka reviewed Dec 13, 2020

View reviewed changes

bin/full-node/src/network_service.rs Outdated Show resolved Hide resolved

expenses added 3 commits December 14, 2020 15:25

Use authorities from the digests

27dc45a

Split into warp_sync function

da147ce

Add a warp sync verifier

9430955

expenses marked this pull request as ready for review January 5, 2021 12:21

tomaka suggested changes Jan 5, 2021

View reviewed changes

expenses and others added 2 commits January 5, 2021 14:20

Merge remote-tracking branch 'origin/main' and remove changes to

6c8356d

bin/full-node

Apply suggestions from code review

c443363

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>

expenses requested a review from tomaka January 5, 2021 13:26

tomaka suggested changes Jan 5, 2021

View reviewed changes

expenses added 2 commits January 5, 2021 15:12

Fix some nits

e426b2e

Add decode_partial to justification/decode.rs

d48d627

expenses requested a review from tomaka January 5, 2021 14:59

expenses and others added 5 commits January 5, 2021 16:53

Verifier nits

752edc7

Remove TryFrom

1348f6f

Merge remote-tracking branch 'origin/main' into ashley-grandpa-warp-sync

902ca03

Fix documentation links

5653569

Merge branch 'main' into ashley-grandpa-warp-sync

13877ed

tomaka enabled auto-merge (squash) January 6, 2021 07:01

tomaka merged commit 06e60d5 into main Jan 6, 2021

tomaka deleted the ashley-grandpa-warp-sync branch January 6, 2021 07:18

tomaka mentioned this pull request Jan 6, 2021

Implement Grandpa warp syncing #270

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Grandpa warp sync#294

Grandpa warp sync#294
tomaka merged 15 commits intomainfrom
ashley-grandpa-warp-sync

expenses commented Dec 10, 2020

Uh oh!

expenses commented Dec 10, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

expenses commented Dec 10, 2020

Uh oh!

expenses commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

expenses commented Dec 10, 2020 •

edited

Loading