Skip to content

polkadot-parachain-primitives should not depend on frame-support.#1897

Merged
bkchr merged 4 commits into
paritytech:masterfrom
JoshOrndorff:joshy-polkadot-primitives-should-not-depend-on-frame
Oct 25, 2023
Merged

polkadot-parachain-primitives should not depend on frame-support.#1897
bkchr merged 4 commits into
paritytech:masterfrom
JoshOrndorff:joshy-polkadot-primitives-should-not-depend-on-frame

Conversation

@JoshOrndorff

@JoshOrndorff JoshOrndorff commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

This PR does not make any functional changes to the code. Rather, it restructures the dependency graph.

Before this PR, the crate polkadot-parachain-primitives depended directly on the crate frame-support. This is wrong in principal because a parachain does not necessarily have anything to do with frame.

This dependency was only for the Weight type which was just a re-export from sp-weights anyway. So this PR changes the dependency to be directly on the much lighter sp-weights.

Depend on sp-weights instead of frame-support.
7fca24a 
The latter is jsut a re-export of the former, but it brings a lot of baggage to the dependency graph for projects that are not using frame.
@ordian

ordian commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

bot fmt

@command-bot

command-bot Bot commented Oct 16, 2023 •
edited
Loading

Copy link
Copy Markdown

@ordian https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3977746 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 51-f7e440a1-6cc5-4171-8b91-0e2a98ef73d0 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot

command-bot Bot commented Oct 16, 2023

Copy link
Copy Markdown

@ordian Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3977746 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3977746/artifacts/download.

@ordian ordian added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Oct 16, 2023
@bkchr bkchr enabled auto-merge (squash) October 20, 2023 09:19
@JoshOrndorff

JoshOrndorff commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Just checking in here. Is there anything I can do to help get this merged?

@bkchr bkchr merged commit bdf1868 into paritytech:master Oct 25, 2023
ordian added a commit that referenced this pull request Oct 26, 2023
@ordian
Merge branch 'master' into tsv-disabling
5a6ad28 
* master:
  Removed TODO from test-case for hard-coded delivery fee estimation (#2042)
  Expose collection attributes from `Inspect` trait (#1914)
  `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897)
  [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)
  Sort the benchmarks before listing them (#2026)
  publish pallet-root-testing (#2017)
  Contracts: Add benchmarks to include files (#2022)
  Small optimisation to `--profile dev` wasm builds (#1851)
  basic-authorship: Improve time recording and logging (#2010)
  Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815)
  [ci] Run check-rust-feature-propagation in pr and master (#2012)
  Improve features dev-ex (#1831)
  Remove obsolete comment. (#2008)
ordian added a commit that referenced this pull request Oct 26, 2023
@ordian
Merge branch 'tsv-disabling' into tsv-disabling-runtime
ff577a5 
* tsv-disabling:
  Removed TODO from test-case for hard-coded delivery fee estimation (#2042)
  Expose collection attributes from `Inspect` trait (#1914)
  `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897)
  [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)
  Sort the benchmarks before listing them (#2026)
  publish pallet-root-testing (#2017)
  Contracts: Add benchmarks to include files (#2022)
  Small optimisation to `--profile dev` wasm builds (#1851)
  basic-authorship: Improve time recording and logging (#2010)
  Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815)
  [ci] Run check-rust-feature-propagation in pr and master (#2012)
  Improve features dev-ex (#1831)
  Remove obsolete comment. (#2008)
ordian added a commit that referenced this pull request Oct 26, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-statement-distribution
73ed217 
* tsv-disabling: (36 commits)
  Removed TODO from test-case for hard-coded delivery fee estimation (#2042)
  Expose collection attributes from `Inspect` trait (#1914)
  `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897)
  [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)
  Sort the benchmarks before listing them (#2026)
  publish pallet-root-testing (#2017)
  Contracts: Add benchmarks to include files (#2022)
  Small optimisation to `--profile dev` wasm builds (#1851)
  basic-authorship: Improve time recording and logging (#2010)
  Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815)
  [ci] Run check-rust-feature-propagation in pr and master (#2012)
  Improve features dev-ex (#1831)
  Remove obsolete comment. (#2008)
  Refactor candidates test in paras_inherent (#2004)
  PVF: Add worker check during tests and benches (#1771)
  Bump actions/setup-node from 3.8.1 to 4.0.0 (#1997)
  polkadot: enable tikv-jemallocator/unprefixed_malloc_on_supported_platforms (#2002)
  Make `IdentityInfo` generic in `pallet-identity` (#1661)
  Ensure correct variant count in `Runtime[Hold/Freeze]Reason` (#1900)
  `CheckWeight`: Add more logging (#1996)
  ...
s0me0ne-unkn0wn pushed a commit that referenced this pull request Oct 29, 2023
@JoshOrndorff @s0me0ne-unkn0wn
polkadot-parachain-primitives should not depend on frame-support. (…
b8de7e8 
…#1897)

This PR does not make any functional changes to the code. Rather, it
restructures the dependency graph.

Before this PR, the crate `polkadot-parachain-primitives` depended
directly on the crate `frame-support`. This is wrong in principal
because a parachain does not necessarily have anything to do with frame.

This dependency was only for the `Weight` type which was just a
re-export from `sp-weights` anyway. So this PR changes the dependency to
be directly on the much lighter `sp-weights`.

---------

Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com>
Co-authored-by: command-bot <>
JoshOrndorff added a commit to Off-Narrative-Labs/polkadot-sdk that referenced this pull request Nov 22, 2023
@JoshOrndorff
polkadot-parachain-primitives should not depend on frame-support. (…
5fbfba1 
…paritytech#1897)

This PR does not make any functional changes to the code. Rather, it
restructures the dependency graph.

Before this PR, the crate `polkadot-parachain-primitives` depended
directly on the crate `frame-support`. This is wrong in principal
because a parachain does not necessarily have anything to do with frame.

This dependency was only for the `Weight` type which was just a
re-export from `sp-weights` anyway. So this PR changes the dependency to
be directly on the much lighter `sp-weights`.

---------

Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com>
Co-authored-by: command-bot <>
JoshOrndorff pushed a commit to Off-Narrative-Labs/Tuxedo that referenced this pull request Nov 22, 2023
Pick paritytech/polkadot-sdk#1897 into our target branch
81f12c5
JoshOrndorff added a commit to Off-Narrative-Labs/Tuxedo that referenced this pull request Nov 28, 2023
@JoshOrndorff @muraca
Parachain support (#130)
0653fbe 
* copy in parachain template, and sort out cargo.toml

* Stub in collect collation info api

* Copy in key parts of pallet parachain system

* kick can down road on inherent scraping

* scribble idea about calling existing runtime apis from validate block

* change default paraid to 2000

* Install proper inherent data providers in collator client-side.

* Install parachain piece in the runtime

* Add zombienet config

* feature gate parachain aspects of runtime and restore working standalone node.

* Testing Validate block is tricky because the `validate_block` function is only built to wasm. I think it has to be that way because overwriting host functions... Maybe there is more to be explored here, but I found it not that rewarding of a direction. Feel free to explore more especially if we get desperate.

* Unit tests for parachain piece

* Proper hrmp watermark. Achieve working POC 🤵‍♂️🤱🍆🪂⛓️👶❗️

* Use TuxedoGenesisBlockBuilder in parachain service

* Use modified `ExportGenesisState` aka `ExportGenesisHead` command.

* Parachain docker image

* Switch branch to 1.3.0 fork
    Pick paritytech/polkadot-sdk#1897 into our target branch

* Bring in dev service and enable it exactly when using --dev

---------

Co-authored-by: Matteo Muraca <56828990+muraca@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions Bot mentioned this pull request Mar 13, 2024
Closed
aiden94a added a commit to aiden94a/Tuxedo that referenced this pull request Sep 7, 2025
@aiden94a @muraca
Parachain support (#130)
c4b123f 
* copy in parachain template, and sort out cargo.toml

* Stub in collect collation info api

* Copy in key parts of pallet parachain system

* kick can down road on inherent scraping

* scribble idea about calling existing runtime apis from validate block

* change default paraid to 2000

* Install proper inherent data providers in collator client-side.

* Install parachain piece in the runtime

* Add zombienet config

* feature gate parachain aspects of runtime and restore working standalone node.

* Testing Validate block is tricky because the `validate_block` function is only built to wasm. I think it has to be that way because overwriting host functions... Maybe there is more to be explored here, but I found it not that rewarding of a direction. Feel free to explore more especially if we get desperate.

* Unit tests for parachain piece

* Proper hrmp watermark. Achieve working POC 🤵‍♂️🤱🍆🪂⛓️👶❗️

* Use TuxedoGenesisBlockBuilder in parachain service

* Use modified `ExportGenesisState` aka `ExportGenesisHead` command.

* Parachain docker image

* Switch branch to 1.3.0 fork
    Pick paritytech/polkadot-sdk#1897 into our target branch

* Bring in dev service and enable it exactly when using --dev

---------

Co-authored-by: Matteo Muraca <56828990+muraca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

+2 more reviewers

@ordian ordian ordian approved these changes

@gupnik gupnik gupnik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoshOrndorff @ordian @bkchr @gupnik @patriciobcs