This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[Revert] Use XCM V3 for initiate_teleport weight calc #2102#2394
Merged
gilescope merged 5 commits intorelease-parachains-v9400from Mar 29, 2023
Merged
[Revert] Use XCM V3 for initiate_teleport weight calc #2102#2394gilescope merged 5 commits intorelease-parachains-v9400from
gilescope merged 5 commits intorelease-parachains-v9400from
Conversation
muharem
reviewed
Mar 28, 2023
Contributor
muharem
left a comment
There was a problem hiding this comment.
@EgorPopelyaev why we wanna revert?
Contributor
Because the message constructed on the Polkadot side uses |
bkontur
approved these changes
Mar 29, 2023
gilescope
approved these changes
Mar 29, 2023
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
This was referenced Mar 29, 2023
Merged
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 30, 2023
…2402) * Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 30, 2023
…2403) * Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts changes made in #2102 because of #2392