Skip to content

config - implement Match final#1907

Merged
bitprophet merged 2 commits intoparamiko:mainfrom
commonism:match-final
Jul 28, 2023
Merged

config - implement Match final#1907
bitprophet merged 2 commits intoparamiko:mainfrom
commonism:match-final

Conversation

@commonism
Copy link
Contributor

This PR adds the glue required to parse & process Match final blocks.

@commonism
Copy link
Contributor Author

Match final was published with OpenSSH 8.0 at 2019-04-17 (https://www.openssh.com/txt/release-8.0)
It's commonly used for ProxyJump configurations, I would appreciate if this could get merged.
I use this for a year already, without any problems.

@bskinn
Copy link
Contributor

bskinn commented Dec 6, 2022

Sorry for the wait on this, @commonism -- thanks very much for the implementation.

One thing I don't see is any documentation of the support. I'm not intimately familiar with the docs, but that would be one thing to look into adding.

More broadly, though: bitprophet is in the middle of a campaign to drop Python 2 and older 3.x on all of his projects, along with some other needed modernization work. paramiko is on a feature freeze until that's done. So, we'll get to this at some point in the future, but it's likely not going to be in the near term.

Once the docs question is resolved, I'll flag it for review--it'll get sorted into a milestone from there, and we'll have a better idea at that point of the timeline.

@commonism
Copy link
Contributor Author

I'll look into adjusting Match: fully supported, with the following caveats: to match the current featureset.

@commonism commonism force-pushed the match-final branch 5 times, most recently from 071b770 to 368e2ca Compare June 29, 2023 08:15
@commonism
Copy link
Contributor Author

rebased & linted

@bskinn
Copy link
Contributor

bskinn commented Jun 29, 2023

Thanks for the bump, @commonism.

Have you had a chance to look into where a note about this new feature should be added to the docs?

Also, this will need an entry in /sites/www/changelog.rst.

@commonism
Copy link
Contributor Author

I added a note to the Match documentation with keywords supported as of today, adding "final".
Does not suffice?

Will look into adding a changelog entry.

@bskinn
Copy link
Contributor

bskinn commented Jun 29, 2023

My bad!!! I overlooked that when I scanned the PR earlier.

@commonism
Copy link
Contributor Author

added in 31e60cc

bitprophet added a commit that referenced this pull request Jul 28, 2023
@bitprophet bitprophet merged commit 71de0cc into paramiko:main Jul 28, 2023
@bitprophet
Copy link
Member

Thanks for this! Just tidied up a bit & merged.

@commonism commonism deleted the match-final branch November 22, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants