Conversation
mattsse
requested changes
Dec 6, 2025
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
this makes a lot of sense and is way easier than what I previously attempted
smol suggestion and a doc nit
we might also want to take the avail cores into account here but unsure because rayon already handles the bridging based on available threads
shekhirin
approved these changes
Dec 8, 2025
DaniPopes
approved these changes
Dec 8, 2025
Zygimantass
pushed a commit
to tempoxyz/tempo
that referenced
this pull request
Dec 8, 2025
Bumps Reth to include paradigmxyz/reth#20169 and paradigmxyz/reth#20164 --------- Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
yongkangc
approved these changes
Dec 9, 2025
yongkangc
pushed a commit
that referenced
this pull request
Dec 9, 2025
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
4 tasks
madisoncarter1234
added a commit
to madisoncarter1234/base
that referenced
this pull request
Dec 31, 2025
Addresses base#282 - reduces sender recovery overhead during flashblock processing. ## Changes - Add rayon for parallel iteration over transactions - Batch ECDSA sender recovery upfront using par_iter() - Add sender_recovery_duration metric for observability - Preserve cache lookup behavior (check prev_pending_blocks first) - Maintain original error handling semantics ## Technical Approach Follows upstream reth pattern (paradigmxyz/reth#20169) - recover all senders in parallel before the sequential transaction processing loop. ## Testing All 10 existing flashblocks tests pass. ## Note Benchmarks not included as benchmark infrastructure was removed from main. The new sender_recovery_duration metric can be used for production measurement.
madisoncarter1234
added a commit
to madisoncarter1234/base
that referenced
this pull request
Jan 1, 2026
Addresses base#282 - reduces sender recovery overhead during flashblock processing. ## Changes - Add rayon for parallel iteration over transactions - Batch ECDSA sender recovery upfront using par_iter() - Add sender_recovery_duration metric for observability - Preserve cache lookup behavior (check prev_pending_blocks first) - Maintain original error handling semantics ## Technical Approach Follows upstream reth pattern (paradigmxyz/reth#20169) - recover all senders in parallel before the sequential transaction processing loop. ## Testing All 10 existing flashblocks tests pass. ## Note Benchmarks not included as benchmark infrastructure was removed from main. The new sender_recovery_duration metric can be used for production measurement.
madisoncarter1234
added a commit
to madisoncarter1234/base
that referenced
this pull request
Jan 2, 2026
Addresses base#282 - reduces sender recovery overhead during flashblock processing. ## Changes - Add rayon for parallel iteration over transactions - Batch ECDSA sender recovery upfront using par_iter() - Add sender_recovery_duration metric for observability - Preserve cache lookup behavior (check prev_pending_blocks first) - Maintain original error handling semantics ## Technical Approach Follows upstream reth pattern (paradigmxyz/reth#20169) - recover all senders in parallel before the sequential transaction processing loop. ## Testing All 10 existing flashblocks tests pass. ## Note Benchmarks not included as benchmark infrastructure was removed from main. The new sender_recovery_duration metric can be used for production measurement.
refcell
pushed a commit
to base/base
that referenced
this pull request
Jan 7, 2026
* fix(ci): use dynamic registry namespace for Docker workflow * feat(flashblocks): parallelize sender recovery Addresses #282 - reduces sender recovery overhead during flashblock processing. ## Changes - Add rayon for parallel iteration over transactions - Batch ECDSA sender recovery upfront using par_iter() - Add sender_recovery_duration metric for observability - Preserve cache lookup behavior (check prev_pending_blocks first) - Maintain original error handling semantics ## Technical Approach Follows upstream reth pattern (paradigmxyz/reth#20169) - recover all senders in parallel before the sequential transaction processing loop. ## Testing All 10 existing flashblocks tests pass. ## Note Benchmarks not included as benchmark infrastructure was removed from main. The new sender_recovery_duration metric can be used for production measurement. * refactor(flashblocks): use tuples for parallel sender recovery * bench(flashblocks): add sender recovery benchmark * chore: format * add sender_recovery bench with real Base blocks --------- Co-authored-by: Haardik <haardik@haardik.dev>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
Bumps Reth to include paradigmxyz/reth#20169 and paradigmxyz/reth#20164 --------- Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
haardikk21
added a commit
to base/base
that referenced
this pull request
Mar 17, 2026
* fix(ci): use dynamic registry namespace for Docker workflow * feat(flashblocks): parallelize sender recovery Addresses #282 - reduces sender recovery overhead during flashblock processing. ## Changes - Add rayon for parallel iteration over transactions - Batch ECDSA sender recovery upfront using par_iter() - Add sender_recovery_duration metric for observability - Preserve cache lookup behavior (check prev_pending_blocks first) - Maintain original error handling semantics ## Technical Approach Follows upstream reth pattern (paradigmxyz/reth#20169) - recover all senders in parallel before the sequential transaction processing loop. ## Testing All 10 existing flashblocks tests pass. ## Note Benchmarks not included as benchmark infrastructure was removed from main. The new sender_recovery_duration metric can be used for production measurement. * refactor(flashblocks): use tuples for parallel sender recovery * bench(flashblocks): add sender recovery benchmark * chore: format * add sender_recovery bench with real Base blocks --------- Co-authored-by: Haardik <haardik@haardik.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.