chore(engine): Remove ConsistentDbView by mediocregopher · Pull Request #19188 · paradigmxyz/reth

mediocregopher · 2025-10-21T15:04:38Z

This PR replaces usage of ConsistenDbView with the OverlayStateProviderFactory. The OverlayStateProviderFactory will handle reverting both hashed and trie state to the correct target block whenever a new tx is made, as well as applying any necessary in-memory overlay on top of that.

mediocregopher · 2025-10-21T15:09:46Z

crates/engine/tree/src/tree/payload_processor/multiproof.rs

 /// Input parameters for spawning a dedicated storage multiproof calculation.
 #[derive(Debug)]
 struct StorageMultiproofInput {
-    config: MultiProofConfig,


MultiProofConfig is how we previously conveyed reverts+in-memory overlay to the proof tasks. OverlayStateProvider now does this job, so it's not necessary to convey the config anymore.

The prefix_sets field of the config is no longer applicable either, as we are always generating proofs off a DB state where hashed state and trie tables are at the same block.

mediocregopher · 2025-10-21T15:18:18Z

crates/engine/tree/src/tree/payload_validator.rs

                // Use state root task only if prefix sets are empty, otherwise proof generation is
                // too expensive because it requires walking all paths in every proof.
                let spawn_start = Instant::now();
-                let (handle, strategy) = if trie_input.prefix_sets.is_empty() {


I'm not sure that prefix_sets ever wasn't empty, but it definitely is always empty now

mediocregopher · 2025-10-21T15:19:37Z

crates/engine/tree/src/tree/payload_validator.rs

            .ok_or_else(|| ProviderError::BlockHashNotFound(historical.as_hash().unwrap()))?;

-        // Retrieve revert state for historical block.
-        let (revert_state, revert_trie) = if block_number == best_block_number {


Reverts are now handled by the OverlayStateProviderFactory, it's only necessary to collect the highest persisted ancestor block number here (so that the OverlayStateProviderFactory knows which block to revert to) and any in-memory overlay data

mediocregopher · 2025-10-21T15:26:55Z

crates/storage/storage-api/src/database_provider.rs

 pub type FactoryTx<F> = <<F as DatabaseProviderFactory>::DB as Database>::TX;

+/// A trait which can be used to describe any factory-like type which returns a read-only provider.
+pub trait DatabaseProviderROFactory {


This trait serves multiple purposes:

Allow passing OverlayStateProviderFactory as a generic throughout the code, which will help keep things flexible in the future.

By not constraining Provider to DBProvider here we don't force OverlayStateProvider to expose its inner TX, which will make it difficult to misuse.

Allows us to constrain the Provider to be TrieCursorFactory + HashedCursorFactory. The alternative would be defining two new TrieCursorFactoryFactory + HashedCursorFactoryFactory traits, which seemed worse.

mediocregopher · 2025-10-21T15:28:42Z

crates/trie/parallel/benches/root.rs

        }

-        let view = ConsistentDbView::new(provider_factory.clone(), None);
+        let view = OverlayStateProviderFactory::new(provider_factory.clone());


If we could add a blanket implementation for TrieCursorFactory and HashedCursorFactory on DBProvider, then (combined with the DatabaseProviderROFactory blanket implementation in this PR) I don't think wrapping this factory would be necessary. But doing that created some import cycles so I left it alone for now.

gakonst · 2025-10-21T15:59:00Z

is this a chore improvement or does it unlock other things?

When determining the available range of trie changeset data we previously only took into account the StageCheckpoint. This was wrong for two reasons: * The StageCheckpoint can have its inner block range cleared, specifically on unwind or reorgs. So we can't rely on the starting bound being present. * The StageCheckpoint's lower bound doesn't get updated by pruning, only the prune checkpoint does. So in general we'll want to rely on the prune checkpoint.

…iocregopher/18906-rm-consistentdbview

jenpaff · 2025-10-22T10:17:52Z

is this a chore improvement or does it unlock other things?

chore but major milestone for us towards simplifying core abstractions which was enabled by #18460

…6-rm-consistentdbview

shekhirin · 2025-10-27T16:24:56Z

crates/engine/tree/src/tree/payload_processor/mod.rs

+
+        // We rely on the cursor factory to provide whatever DB overlay is necessary to see a
+        // consistent view of the database, including the trie tables. Because of this there is no
+        // need for an overarching prefix set to invalidate any section of the trie tables, and so
+        // we use an empty prefix set.
+        let prefix_sets = Arc::new(TriePrefixSetsMut::default());


can prefix_sets be removed from ProofTaskCtx too then?

I think so yes, I had thought it would be good to keep it around in case we wanted to/needed to use it for some future use-case, but at the moment removing it would be possible.

can do as a follow-up, just nicer to not pass defaults everywhere if it's unused anyway

mediocregopher · 2025-10-27T16:30:06Z

crates/storage/provider/src/providers/state/overlay.rs

-            })
-        };
+        // Use the higher of the two lower bounds. If neither is available assume unbounded.
+        let lower_bound = stage_lower_bound.max(prune_lower_bound).unwrap_or(0);


Without this change the e2e tests wouldn't complete, because they don't run a pipeline to set the PruneCheckpoint. I think it's fine generally, as we shouldn't ever have a real condition where the PruneCheckpoint wouldn't be set.

I think this is fine

crates/trie/parallel/benches/root.rs

shekhirin · 2025-10-27T16:45:36Z

crates/trie/parallel/src/proof.rs

 /// that has proof targets.
 #[derive(Debug)]
 pub struct ParallelProof {
-    /// The sorted collection of cached in-memory intermediate trie nodes that


oh, this was already unused 👍

Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>

shekhirin · 2025-10-27T17:03:38Z

crates/engine/tree/src/tree/payload_validator.rs


        // Plan the strategy used for state root computation.
-        let state_root_plan = self.plan_state_root_computation(&input, &ctx);
-        let persisting_kind = state_root_plan.persisting_kind;


PersistingKind can be removed completely in a follow-up PR

shekhirin · 2025-10-27T17:09:03Z

crates/engine/tree/src/tree/payload_validator.rs

-                                StateRootStrategy::Parallel,
-                            )
-                        }
+                let (handle, strategy) = match self.payload_processor.spawn(


unrelated to this PR: I don't think self.payload_processor.spawn is actually fallible, should be possible to simplify this even more without a fallback to self.payload_processor.spawn_cache_exclusive, can be done in a follow-up PR

can we track this @shekhirin

shekhirin · 2025-10-27T17:09:39Z

crates/engine/tree/src/tree/payload_validator.rs

-                StateRootStrategy::Parallel
-            }
-        } else {
+    fn plan_state_root_computation(&self) -> StateRootPlan {


can be done in a follow-up PR: can just return an enum now, the function is much simpler

shekhirin · 2025-10-27T17:11:49Z

crates/engine/tree/src/tree/payload_validator.rs

-            (revert_state, revert_trie)
-        };
-
-        input.append_cached(revert_trie.into(), revert_state);


checks out, this was needed only for reverting the trie state

shekhirin

LGTM, only nits and follow-ups for cleanup

…rm-consistentdbview

Rjected

this makes sense to me, also just nits that can be done as a follow up

Rjected · 2025-10-27T17:32:27Z

crates/engine/tree/src/tree/payload_validator.rs

+        // The `hashed_state` argument is already taken into account as part of the overlay, but we
+        // need to use the prefix sets which were generated from it to indicate to the
+        // ParallelStateRoot which parts of the trie need to be recomputed.
+        let prefix_sets = Arc::into_inner(multiproof_config.prefix_sets)
+            .expect("MultiProofConfig was never cloned")
+            .freeze();


the use of into_inner here makes me think we should have a function that constructs a MultiProofConfig from trie input, that gives us back the original prefix sets.

Rjected · 2025-10-27T17:43:41Z

crates/trie/parallel/src/proof_task.rs

+    // Create provider from factory
+    let provider = task_ctx
+        .factory
+        .database_provider_ro()
+        .expect("Account worker failed to initialize: unable to create provider");


nit for followup - we should make this fn return a Result<()> so we can just propagate this error

mattsse

awesome

this now unlocks a ton of additional simplifications

mattsse · 2025-10-27T18:50:25Z

crates/engine/tree/src/tree/payload_processor/mod.rs

-    /// A cleared trie input, kept around to be reused so allocations can be minimized.
-    trie_input: Option<TrieInput>,


mattsse · 2025-10-27T18:51:00Z

crates/engine/tree/src/tree/payload_validator.rs


        // Plan the strategy used for state root computation.
-        let state_root_plan = self.plan_state_root_computation(&input, &ctx);
-        let persisting_kind = state_root_plan.persisting_kind;


mattsse · 2025-10-27T18:55:57Z

crates/engine/tree/src/tree/payload_validator.rs

+        let provider = self.provider.database_provider_ro()?;
+
+        let (mut input, block_number) =
+            self.compute_trie_input(provider, parent_hash, state, None)?;


I think all of this is tracked in #19250

mattsse · 2025-10-27T18:56:43Z

crates/engine/tree/src/tree/payload_validator.rs

-                                StateRootStrategy::Parallel,
-                            )
-                        }
+                let (handle, strategy) = match self.payload_processor.spawn(


can we track this @shekhirin

mattsse · 2025-10-27T18:57:50Z

crates/storage/provider/src/providers/state/overlay.rs

-            })
-        };
+        // Use the higher of the two lower bounds. If neither is available assume unbounded.
+        let lower_bound = stage_lower_bound.max(prune_lower_bound).unwrap_or(0);


I think this is fine

This reverts commit ffeaa47.

This reverts commit 4fecad0.

* chore: lower ecies instrument calls to trace (paradigmxyz#19004) * fix: add revm-state to dev-dependencies of chain-state crate (paradigmxyz#19044) * fix(sim): clamp bundle timeout to max instead of falling back to default (paradigmxyz#18840) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * fix(cli): remove redundant EthChainSpec bound in run_with_components (paradigmxyz#19106) * feat: convert blobs at RPC (paradigmxyz#19084) * fix: add bundle and transaction context to call_many errors (paradigmxyz#18127) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * chore: add comment section for claude (paradigmxyz#19108) * feat: derive dev accounts from mnemonic in dev mode (paradigmxyz#18299) Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com> * refactor: naming fix for multiproof dispatch (paradigmxyz#19102) * fix: Deduplicate hashed storage preparation in MemoryOverlayStateProvider (paradigmxyz#19087) * feat: convert pooled blobs transition (paradigmxyz#19095) * feat(engine): improve payload validator tracing spans (paradigmxyz#18960) Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com> * feat: add capacity metrics for tries (paradigmxyz#19117) * feat(cli): Reuse a single StaticFileProducer across file import chunks (paradigmxyz#18964) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * feat(stateless): make UncompressedPublicKey serializable (paradigmxyz#19115) Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * docs: fix wrong label for `--color=auto` (paradigmxyz#19110) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * chore: fix clippy (paradigmxyz#19118) * fix(net): correct error messages for decrypt and header paths (paradigmxyz#19039) * chore: remove redundant collect in debug trace (paradigmxyz#19121) * chore(deps): weekly `cargo update` (paradigmxyz#19126) Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * fix: Remove duplicate debug log in write_blocks_to_rlp (paradigmxyz#19132) * feat: add helper apply fns (paradigmxyz#19122) * fix(e2e): gracefully wait for payload (paradigmxyz#19137) * fix: Add support for init-state for op-reth chains that are not op-mainnet… (paradigmxyz#19116) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * chore(trie): Add lifetime to cursors returned from Trie/HashedCursorFactorys (paradigmxyz#19114) * chore: fix+update nix flake (paradigmxyz#19142) * Revert "refactor: unify `Pipeline` creation codepaths" (paradigmxyz#19143) * fix(prune): Disable pruning limits (paradigmxyz#19141) * fix: remove tautological assertions in validator tests (paradigmxyz#19134) * chore(config): clean up gas limit code (paradigmxyz#19144) * perf: batch byte for serialization (paradigmxyz#19096) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * fix: Revert "feat(engine): improve payload validator tracing spans (paradigmxyz#18960)" (paradigmxyz#19145) * chore: rm high frequency otel-related debug logs (paradigmxyz#19147) * perf: fix redundant Arc clone in file_client tests (paradigmxyz#19170) * feat(storage): replace unreachable todo!() with explicit unreachable!() in compact derive (paradigmxyz#19152) * chore: remove total difficulty from `HeaderProvider` (paradigmxyz#19151) * fix(cli): prune config saving to file (paradigmxyz#19174) * refactor: remove `FullNodePrimitives` (paradigmxyz#19176) * refactor(ipc): simplify RpcServiceCfg from enum to struct (paradigmxyz#19180) * chore: fix incorrect hex value in comment (0x2A instead of 0x7E) (paradigmxyz#19181) * feat(e2e): add builder API for configuring test node setups (paradigmxyz#19146) * fix: remove unnecessary trait bounds in extend_sorted_vec helper (paradigmxyz#19154) * fix: drop support for total difficulty table (paradigmxyz#16660) Co-authored-by: Aditya Pandey <adityapandey@Adityas-MacBook-Air.local> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com> * chore: fix misleading log message for body size check (paradigmxyz#19173) * feat: improve oversized data error message (paradigmxyz#19190) * chore: rm generic array dep from discv4 (paradigmxyz#19140) * docs: improve SealedBlockRecoveryError documentation (paradigmxyz#19120) * test: add node record parse test (paradigmxyz#19172) * fix: add arrayvec to dev-dependencies in reth-trie-common (paradigmxyz#19192) * feat(engine): improve payload validator tracing spans 2 (paradigmxyz#19155) * refactor: decouple max proof task concurrency from inflight proof limits (paradigmxyz#19171) * chore: remove rkrasiuk from codeowners (paradigmxyz#19206) * perf(net): convert Bytes to BytesMut to avoid reallocation (paradigmxyz#19204) * refactor(prune): remove receipts log filter segment (paradigmxyz#19184) * fix: small features fix (paradigmxyz#19212) * perf: check prewarm termination multiple times (paradigmxyz#19214) * chore: only alloc required capacity (paradigmxyz#19217) * fix: captured impl trait lifetime (paradigmxyz#19216) Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: OverlayStateProviderFactory: validating trie changeset range and revert target (paradigmxyz#19207) * feat: warning log when blocked on execution cache (paradigmxyz#19222) * fix(reth-bench): Lower block channel capacity and make it configurable (paradigmxyz#19226) * chore: use retrylayer for benchmarkcontext (paradigmxyz#19227) * fix: incorrect RPC namespace reference (paradigmxyz#19225) * chore: add elapsed info log (paradigmxyz#19211) * test(hive): Ignore new failures that are won't fix (paradigmxyz#19218) * fix: rename consume-* test suite (paradigmxyz#19230) * chore(storage): remove `UnifiedStorageWriterError` (paradigmxyz#19210) * chore(e2e): relax bounds (paradigmxyz#19231) * revert: "fix(engine): flatten storage cache (paradigmxyz#18880)" (paradigmxyz#19235) * fix(node): remove unused ConsensusLayerHealthEvent variants (paradigmxyz#19238) * chore: swap order for canon stream (paradigmxyz#19242) * feat(jovian): track da footprint block limit. Update basefee calculation (paradigmxyz#19048) Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com> * fix(engine): payload processor tracing event targets (paradigmxyz#19223) * perf: rm pending queue from MultiproofManager (paradigmxyz#19178) * docs: correct Payment tx type from 0x7E to 0x2A (paradigmxyz#19255) * fix: use network id in p2p command (paradigmxyz#19252) * feat(prune): Add an empty `reth-prune-db` crate (paradigmxyz#19232) * fix: use known paris activation blocks in genesis parsing (paradigmxyz#19258) * chore: align env filter comment with configured directives (paradigmxyz#19237) * refactor(static-file): remove unused segments (paradigmxyz#19209) * docs: add usage examples and documentation to NoopConsensus (paradigmxyz#19194) * fix(cli): prune CLI argument names (paradigmxyz#19215) * fix(engine): shrink tries after clearing (paradigmxyz#19159) * feat(otlp-tracing): enable to export traces with grpc export with `tracing-otlp` and `tracing-otlp-protocol` arg (paradigmxyz#18985) * fix: return hashed peer key as id (paradigmxyz#19245) * chore: remove db pruning of header/txs segments (paradigmxyz#19260) * chore: rm `StaticFileReceipts` pruner (paradigmxyz#19265) * chore(net): remove unnecessary TODO (paradigmxyz#19268) * feat: eth_fillTransaction (paradigmxyz#19199) Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com> Co-authored-by: jxom <7336481+jxom@users.noreply.github.com> * fix: no_std compatibility in reth-optimism-chainspec (paradigmxyz#19271) * chore: add `add_or_replace_if_module_configured` method (paradigmxyz#19266) * fix(engine): re-insert storage cache and use arc (paradigmxyz#18879) * feat: allow using SafeNoSync for MDBX (paradigmxyz#18945) Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> * fix(optimism): guard follow-up inserts by payload_id to prevent mixed sequences (paradigmxyz#19264) * perf: Eliminate spawn_blocking in multiproof manager (paradigmxyz#19203) * fix: hive tests consume test suite (paradigmxyz#19240) Co-authored-by: Federico Gimenez <federico.gimenez@gmail.com> * feat(trie): proof task tracing improvements (paradigmxyz#19276) * fix(trie): correct comment in sparse_trie_reveal_node_1 test (paradigmxyz#19193) * chore(trie): do not create a parent span for proof worker handle (paradigmxyz#19281) * feat(tracing): set default OTLP log level to WARN (paradigmxyz#19283) * fix(node): classify connect_async failures as WebSocket and use Url parse error (paradigmxyz#19286) * chore(deps): weekly `cargo update` (paradigmxyz#19300) Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com> * refactor(trie): rename queue_storage_proof to send_storage_proof (paradigmxyz#19310) * refactor: add more Snap response types (paradigmxyz#19303) Co-authored-by: suhas-sensei <suhas.ghosal2002@gmail.com> * chore(ethereum): remove redundant std::default::Default import (paradigmxyz#19299) * fix(fs): correct ReadLink error message and add missing read_link wra… (paradigmxyz#19287) * fix(engine): module doc to reflect schnellru::LruMap backend (paradigmxyz#19296) * chore(net): upgrade some noisy spans to TRACE (paradigmxyz#19312) * ci: pin Bun to v1.2.23 (paradigmxyz#19315) * fix(trie): Fix trie_reverts not returning sorted nodes (paradigmxyz#19280) * chore: remove redundant PhantomData from NodeHooks (paradigmxyz#19316) * docs: populate modify-node section with node-custom-rpc implementation guide (paradigmxyz#18672) * chore: use hex bytes type (paradigmxyz#19317) * docs(eth-wire): update docs to reflect eth-wire-types, alloy_rlp, version-aware decoding, and RLPx multiplexing (paradigmxyz#19319) * fix(prune): Add unused variants back to PruneSegment enum (paradigmxyz#19318) * refactor(trie): Unify proof return types (paradigmxyz#19311) * chore: remove dead OpL1BlockInfo.number field and writes (paradigmxyz#19325) * chore(trie): reduce sparse trie tracing (paradigmxyz#19321) * fix(trie): Rewrite InMemoryTrieOverlay (with proptests!) (paradigmxyz#19277) * feat(jovian/block-validation): fix block validation for jovian (paradigmxyz#19304) * docs: improve documentation for mock database and transactions (paradigmxyz#19302) * chore: remove trie capacity metrics (paradigmxyz#19327) * feat(metrics): add push gateway support for Prometheus metrics (paradigmxyz#19243) * chore(engine): Remove ConsistentDbView (paradigmxyz#19188) Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> * fix: update section name in expected failures, add more concise comments (paradigmxyz#19328) * chore: replace `CacheDB` with `State<DB>` in RPC crate (paradigmxyz#19330) Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com> * chore: update Grafana dashboard with split pending multiproof metrics (paradigmxyz#19339) * feat(metrics): improve multiproof worker metrics (paradigmxyz#19337) * chore(deps): bump actions/upload-artifact from 4 to 5 (paradigmxyz#19335) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/download-artifact from 5 to 6 (paradigmxyz#19336) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(engine): Eliminates spurious warning logs in prewarm task (paradigmxyz#19133) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * refactor: make DatabaseProof trait stateful (paradigmxyz#18753) * refactor(trie): reorder proof_task.rs for better code organization (paradigmxyz#19342) * fix(pipeline): ensure we dont pass an outdated target to header stage (paradigmxyz#19351) * chore: update docs for expected test failure (paradigmxyz#19343) * chore: dont write receipts to both storages on archive node (paradigmxyz#19361) * chore: add ChainHardforks::extend (paradigmxyz#19332) * feat(reth-optimism-node): Add OP E2E mineblock test with isthmus activated at genesis (paradigmxyz#19305) * feat: insert at timestamp (paradigmxyz#19365) * fix(op-reth/consensus): fixes header validation for jovian. decouple excess blob gas and blob gas used (paradigmxyz#19338) * refactor(trie): restructure proof task workers into structs (paradigmxyz#19344) * perf: wrap tx with Arc to avoid deep cloning (paradigmxyz#19350) * feat: impl a function to create new instance of TransactionEvents (paradigmxyz#19375) Co-authored-by: Neo Krypt <neo@canxium.org> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * fix(trie): use block hash in OverlayStateProviderFactory (paradigmxyz#19353) * feat: add pruning of transactions from static-files (paradigmxyz#19241) * chore: bump 1.8.3 (paradigmxyz#19379) * fix: Don't always clone in-memory overlays in OverlayStateProviderFactory (paradigmxyz#19383) * fix(op-reth): use latest for runtime image (paradigmxyz#19331) * chore: Update nix flake (paradigmxyz#19386) * feat(jovian/timestamps): add jovian timestamps to op-reth (paradigmxyz#19290) * fix: add more context to expected hive failures (paradigmxyz#19363) Co-authored-by: rakita <rakita@users.noreply.github.com> * feat(rpc): implement `debug_dbGet` (paradigmxyz#19369) * feat(precompiles/jovian): add jovian precompiles to op-reth (paradigmxyz#19333) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * fix(engine): align compute_trie_input docs with actual persistence behavior (paradigmxyz#19385) Co-authored-by: Brian Picciano <me@mediocregopher.com> * fix: remove PersistenceState from TreeCtx (paradigmxyz#19356) * docs: improve RESS protocol module documentation (paradigmxyz#19370) * docs: fix otlp flag in monioring docs (paradigmxyz#19394) * feat(jovian/rpc): update receipts to transmit over RPC with Jovian compatible fields (paradigmxyz#19368) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * chore(primitives-traits): gate test-only modules (paradigmxyz#19393) * feat: display blob params alongside hardfork info (paradigmxyz#19358) * chore: fix unused dep (paradigmxyz#19397) * chore: fix unused warning (paradigmxyz#19395) * perf(codecs): avoid String allocation in proc macro type checking (paradigmxyz#19354) * chore: reuse gzip read buffer to avoid per-iteration allocation (paradigmxyz#19398) * chore: bump discv5 (paradigmxyz#19400) * perf: box ForkId in Peer struct to reduce size (paradigmxyz#19402) * fix(cli): Metrics log when passed metrics port 0 (paradigmxyz#19406) Co-authored-by: Varun Doshi <doshivarun202@gmail.com> * fix(engine): trigger live sync after backfill completes at finalized (paradigmxyz#19390) * fix: Prune checkpoint fixes (paradigmxyz#19407) * fix: accurate build features reporting in `reth --version` (paradigmxyz#19124) * chore(net): avoid cloning GetBlockBodies request (paradigmxyz#19404) * feat: Output the block execution outputs after validating (reth-stateless) (paradigmxyz#19360) * fix(engine): remove redundant parent_to_child cleanup in insert_executed (paradigmxyz#19380) * feat: add --rpc.evm-memory-limit flag (paradigmxyz#19279) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * fix: highest_nonces update in PendingPool::remove_transaction (paradigmxyz#19301) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * chore: add tracing features to node-core crate (paradigmxyz#19415) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * chore: update superchain reg to c9881d543174ff00b8f3a9ad3f31bf4630b9743b (paradigmxyz#19418) * fix(compact): prevent bitflag overflow by using usize accumulator (paradigmxyz#19408) * fix: Properly set MerkleChangeSets checkpoint in stage's fast-path (paradigmxyz#19421) * chore: add count field to trace (paradigmxyz#19422) * fix(codecs): return remaining slice in EIP-1559 from_compact (paradigmxyz#19413) * feat(reth-bench): Default --wait-time to 250ms (paradigmxyz#19425) * perf: bias towards proof results (paradigmxyz#19426) * feat(node): CLI argument for sync state idle when backfill is idle (paradigmxyz#19429) * feat(op-reth): implement miner_setGasLimit RPC (paradigmxyz#19247) Co-authored-by: frankudoags <frankudoags.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * perf: only chunk if more > 1 available (paradigmxyz#19427) * fix(beacon-api-sidecar): use correct block metadata for reorged blobs (paradigmxyz#19424) * chore(codecs): replace todo with unimplemented in Compact derive (paradigmxyz#19284) * fix(txpool): correct propagate field name in Debug output (paradigmxyz#19278) * perf: optimize SyncHeight event handling to avoid recursive calls (paradigmxyz#19372) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * perf(tree): only chunk multiproof targets if needed (paradigmxyz#19326) * fix: rename variable in block_hash method from 'code' to 'hash' (paradigmxyz#19269) * chore(docker): remove apt-get upgrade to ensure reproducible and faster builds (paradigmxyz#19080) * fix: Inline value match in SparseTrie::find_leaf to remove redundant wrapper (paradigmxyz#19138) Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> * perf(cli): optimize StorageChangeSets import in merkle stage dump (paradigmxyz#18022) Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com> Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> * revert: "feat: Add building and publishing of *.deb packages (paradigmxyz#18615)" (paradigmxyz#19011) * feat(tasks): distinguish blocking and non-blocking tasks in metrics (paradigmxyz#18440) Co-authored-by: Nathaniel Bajo <nathanielbajo@Nathaniels-MacBook-Pro.local> Co-authored-by: Emilia Hane <emiliaha95@gmail.com> Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> * feat: support custom Download command defaults (paradigmxyz#19437) * chore: OverlayStateProviderFactory: don't query for reverts unless necessary (paradigmxyz#19412) * chore(deps): weekly `cargo update` (paradigmxyz#19443) Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * chore: add config_mut helpers (paradigmxyz#19436) * fix: avoid unnecessary self.clone() in OpNetworkBuilder::network_config (paradigmxyz#19451) * feat(op-reth): add FlashblocksListeners container and receipt helpers (paradigmxyz#19446) Co-authored-by: Claude <noreply@anthropic.com> * feat: add broadcast channel for received flashblocks (paradigmxyz#19459) Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com> * refactor(prune): derive EnumIter instead of explicit array of segments (paradigmxyz#19465) * feat: schedule fusaka (paradigmxyz#19455) * chore: use name const for cli name (paradigmxyz#19466) * fix(db): OverlayStateProviderFactory: default validation lower bound to 0 (paradigmxyz#19468) * chore: bump revm 31 (paradigmxyz#19470) Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com> * chore: add js-tracer feature to bins (paradigmxyz#19441) * chore(node): compact duration formatting in stage progress logs (paradigmxyz#18720) * fix: update `min_block` on `StaticFileProvider::update_index` (paradigmxyz#19469) * chore(grafana): deduce label by aggregate metrics (paradigmxyz#18550) * chore: Remove unused jsonrpsee tracing import in exex subscription example (paradigmxyz#19448) * chore: add --miner.gaslimit alias (paradigmxyz#19475) * chore: add queued reason to event (paradigmxyz#19476) * feat: add helper to disable discovery (paradigmxyz#19478) * fix(net): remove capacity inflation from buffered blocks size calculation (paradigmxyz#19481) * perf(rpc): use cache for latest block and receipts (paradigmxyz#19483) * perf: use latest hash directly (paradigmxyz#19486) * feat: support pending block tag in eth_getLogs for flashblocks (paradigmxyz#19388) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * docs(trie): fix PrefixSetMut docs and freeze() comment (paradigmxyz#19467) * chore: Various cleanups after consistent DB view removal (paradigmxyz#19489) * feat(reth-bench-compare): upstream from personal repo (paradigmxyz#19488) Co-authored-by: Claude <noreply@anthropic.com> * fix: use cost when checking fee cap (paradigmxyz#19493) * fix: spawn block fetching blocking (paradigmxyz#19491) Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> * chore(op-reth/scr): update superchain-registry configs. Commit 9e3f71cee0e4e2acb4864cb00f5fbee3555d8e9f (paradigmxyz#19495) * perf: improve ethsendrawsync for op with flashblock (paradigmxyz#19462) Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com> * docs(banlist): document timeout update behavior on re-ban (paradigmxyz#19497) * chore: add custom hardforks example (paradigmxyz#19391) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * fix: skip code check in get_transaction_by_sender_and_nonce (paradigmxyz#19502) * chore: bump min ckzg (paradigmxyz#19504) * chore: bump version 1.8.4 (paradigmxyz#19503) * fix: dead link Sentry (paradigmxyz#19505) * chore: bump hardforks (paradigmxyz#19506) * chore: bump v1.9.0 (paradigmxyz#19507) * chore: bump revm v31.0.1 (paradigmxyz#19567) * chore: bump version * chore: bump version to 1.9.2 (paradigmxyz#19647) * chore: bump op-revm v12.0.2 patch (paradigmxyz#19629) * revert: "refactor(prune): remove receipts log filter segment (paradigmxyz#19184)" (paradigmxyz#19646) * ci: use macos-14 runner (paradigmxyz#19658) * fix: add minbasefee for jovian attributes (paradigmxyz#19726) * chore(op-reth/scr): update superchain-registry (paradigmxyz#19806) Co-authored-by: theo <80177219+theochap@users.noreply.github.com> * chore: bump version v1.9.3 (paradigmxyz#19831) * chore: bump to mantle-xyz/revm v2.1.0 * add limb support * bump: revm v2.1.2 --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com> Co-authored-by: futreall <86553580+futreall@users.noreply.github.com> Co-authored-by: maradini77 <140460067+maradini77@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: sashass1315 <sashass1315@gmail.com> Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com> Co-authored-by: crazykissshout <crazykisss111@gmail.com> Co-authored-by: Dharm Singh <153282211+dharmvr1@users.noreply.github.com> Co-authored-by: YK <chiayongkang@hotmail.com> Co-authored-by: leopardracer <136604165+leopardracer@users.noreply.github.com> Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: GarmashAlex <garmasholeksii@gmail.com> Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Dmitry <98899785+mdqst@users.noreply.github.com> Co-authored-by: Micke <155267459+reallesee@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com> Co-authored-by: Andrew Huang <k.andrew.huang@gmail.com> Co-authored-by: Brian Picciano <me@mediocregopher.com> Co-authored-by: Skylar Ray <137945430+sky-coderay@users.noreply.github.com> Co-authored-by: 0xMushow <105550256+0xMushow@users.noreply.github.com> Co-authored-by: malik <aremumalik05@gmail.com> Co-authored-by: Alex Pikme <30472093+reject-i@users.noreply.github.com> Co-authored-by: MozirDmitriy <dmitriymozir@gmail.com> Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com> Co-authored-by: David Klank <155117116+davidjsonn@users.noreply.github.com> Co-authored-by: Brawn <nftdropped@gmail.com> Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com> Co-authored-by: 0xsensei <prblmslvr.aditya@gmail.com> Co-authored-by: Aditya Pandey <adityapandey@Adityas-MacBook-Air.local> Co-authored-by: Merkel Tranjes <140164174+rnkrtt@users.noreply.github.com> Co-authored-by: Avory <avorycorelli@gmail.com> Co-authored-by: robinsdan <115981357+robinsdan@users.noreply.github.com> Co-authored-by: greg <82421016+greged93@users.noreply.github.com> Co-authored-by: wizard <112275929+famouswizard@users.noreply.github.com> Co-authored-by: Roman Hodulák <roman.hodulak@polyglot-software.com> Co-authored-by: Jennifer <jenpaff0@gmail.com> Co-authored-by: radik878 <radikpadik76@gmail.com> Co-authored-by: theo <80177219+theochap@users.noreply.github.com> Co-authored-by: Fallengirl <155266340+Fallengirl@users.noreply.github.com> Co-authored-by: Ragnar <rodiondenmark@gmail.com> Co-authored-by: Léa Narzis <78718413+lean-apple@users.noreply.github.com> Co-authored-by: Yash <72552910+kumaryash90@users.noreply.github.com> Co-authored-by: jxom <7336481+jxom@users.noreply.github.com> Co-authored-by: strmfos <155266597+strmfos@users.noreply.github.com> Co-authored-by: josé v <52646071+Peponks9@users.noreply.github.com> Co-authored-by: 0xeabz <eabz@kindynos.mx> Co-authored-by: Galoretka <galoretochka@gmail.com> Co-authored-by: Federico Gimenez <federico.gimenez@gmail.com> Co-authored-by: AJStonewee <ajston73@gmail.com> Co-authored-by: phrwlk <phrwlk7@gmail.com> Co-authored-by: guha-rahul <52607971+guha-rahul@users.noreply.github.com> Co-authored-by: suhas-sensei <suhas.ghosal2002@gmail.com> Co-authored-by: Maximilian Hubert <64627729+gap-editor@users.noreply.github.com> Co-authored-by: VolodymyrBg <aqdrgg19@gmail.com> Co-authored-by: Gengar <creeptogengar@gmail.com> Co-authored-by: Mablr <59505383+mablr@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Francis Li <lihuiyi0406@gmail.com> Co-authored-by: Karl Yu <43113774+0xKarl98@users.noreply.github.com> Co-authored-by: Đạt Nguyễn <datnguyencse@users.noreply.github.com> Co-authored-by: Neo Krypt <neo@canxium.org> Co-authored-by: emiliano-conduitxyz <emiliano@conduit.xyz> Co-authored-by: rakita <rakita@users.noreply.github.com> Co-authored-by: leniram159 <leniram159@gmail.com> Co-authored-by: Forostovec <ilonaforostovec22@gmail.com> Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Varun Doshi <doshivarun202@gmail.com> Co-authored-by: Lancelot de Ferrière <wraitii@users.noreply.github.com> Co-authored-by: Wojtek Łopata <wojtek@0xproject.com> Co-authored-by: Eric Woolsey <ewoolsey@ualberta.ca> Co-authored-by: Udoagwa Franklin <54338168+frankudoags@users.noreply.github.com> Co-authored-by: bigbear <155267841+aso20455@users.noreply.github.com> Co-authored-by: oooLowNeoNooo <ooolowneonooo@gmail.com> Co-authored-by: FT <140458077+zeevick10@users.noreply.github.com> Co-authored-by: anim001k <140460766+anim001k@users.noreply.github.com> Co-authored-by: MIHAO PARK <wetkeyboard17@gmail.com> Co-authored-by: William Nwoke <willteey@gmail.com> Co-authored-by: Nathaniel Bajo <nathanielbajo@Nathaniels-MacBook-Pro.local> Co-authored-by: Emilia Hane <emiliaha95@gmail.com> Co-authored-by: Doryu <anna.shuraeva16@gmail.com> Co-authored-by: Block Wizard <satorukuame@gmail.com> Co-authored-by: Cypher Pepe <125112044+cypherpepe@users.noreply.github.com>

github-project-automation bot added this to Reth Tracker Oct 21, 2025

github-project-automation bot moved this to Backlog in Reth Tracker Oct 21, 2025

mediocregopher force-pushed the mediocregopher/18906-rm-consistentdbview branch 2 times, most recently from 1e58915 to 50c3d20 Compare October 21, 2025 15:48

mediocregopher commented Oct 21, 2025

View reviewed changes

chore(engine): Remove ConsistentDbView

50c3d20

mediocregopher added 4 commits October 22, 2025 10:31

Merge branch 'mediocregopher/merkle-changesets-validate-fix' into med…

05e519e

…iocregopher/18906-rm-consistentdbview

Fix compilation errors after merge

15221ec

Fix OverlayStateProviderFactory reverting to wrong block number

9404f81

mediocregopher added 2 commits October 22, 2025 14:40

Merge remote-tracking branch 'upstream/main' into mediocregopher/1890…

902ae06

…6-rm-consistentdbview

Simplify compute_trie_updates further, no more persisting action check

fe51aef

mediocregopher force-pushed the mediocregopher/18906-rm-consistentdbview branch from 16bdc39 to fe51aef Compare October 27, 2025 11:10

mediocregopher changed the base branch from main to mediocregopher/in-mem-trie-overlay-fix October 27, 2025 11:13

mediocregopher added 2 commits October 27, 2025 13:59

Merge remote-tracking branch 'upstream/main' into mediocregopher/1890…

6e5b299

…6-rm-consistentdbview

Fix parallel root test

8504f4a

Base automatically changed from mediocregopher/in-mem-trie-overlay-fix to main October 27, 2025 15:34

mediocregopher marked this pull request as ready for review October 27, 2025 16:11

mediocregopher requested review from Rjected, fgimenez, gakonst, joshieDo, mattsse, rakita, shekhirin and yongkangc as code owners October 27, 2025 16:11

Fix checkpoint validation and docs

c2892cb

shekhirin reviewed Oct 27, 2025

View reviewed changes

mediocregopher commented Oct 27, 2025

View reviewed changes

shekhirin reviewed Oct 27, 2025

View reviewed changes

crates/trie/parallel/benches/root.rs Outdated Show resolved Hide resolved

shekhirin reviewed Oct 27, 2025

View reviewed changes

mediocregopher and others added 2 commits October 27, 2025 17:48

Update crates/trie/parallel/benches/root.rs

403930e

Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>

fix bench

c1010b9

shekhirin reviewed Oct 27, 2025

View reviewed changes

shekhirin approved these changes Oct 27, 2025

View reviewed changes

github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 27, 2025

Merge remote-tracking branch 'origin/main' into mediocregopher/18906-…

a360554

…rm-consistentdbview

Rjected approved these changes Oct 27, 2025

View reviewed changes

mattsse approved these changes Oct 27, 2025

View reviewed changes

shekhirin added this pull request to the merge queue Oct 27, 2025

Merged via the queue into main with commit ffeaa47 Oct 27, 2025
45 checks passed

shekhirin deleted the mediocregopher/18906-rm-consistentdbview branch October 27, 2025 19:24

github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 27, 2025

shekhirin mentioned this pull request Oct 28, 2025

Payload validator cleanup after ConsistentDbView removal #19341

Closed

mediocregopher mentioned this pull request Oct 28, 2025

Remove consistentviewDB #18906

Closed

yongkangc pushed a commit that referenced this pull request Oct 30, 2025

Revert "chore(engine): Remove ConsistentDbView (#19188)"

4fecad0

This reverts commit ffeaa47.

yongkangc pushed a commit that referenced this pull request Oct 30, 2025

Reapply "chore(engine): Remove ConsistentDbView (#19188)"

def9cdd

This reverts commit 4fecad0.

		/// A cleared trie input, kept around to be reused so allocations can be minimized.
		trie_input: Option<TrieInput>,

Conversation

mediocregopher commented Oct 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mediocregopher Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gakonst commented Oct 21, 2025

Uh oh!

jenpaff commented Oct 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shekhirin left a comment

Choose a reason for hiding this comment

Uh oh!

Rjected left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mediocregopher Oct 21, 2025 •

edited

Loading