Skip to content

fix(rpc/engine): check osaka in getBlobsV1#18669

Merged
mattsse merged 5 commits intoparadigmxyz:mainfrom
jsvisa:get-blob-v1
Sep 26, 2025
Merged

fix(rpc/engine): check osaka in getBlobsV1#18669
mattsse merged 5 commits intoparadigmxyz:mainfrom
jsvisa:get-blob-v1

Conversation

@jsvisa
Copy link
Copy Markdown
Contributor

@jsvisa jsvisa commented Sep 24, 2025

Similar to ethereum/go-ethereum#32731, add a check the activation of osaka in getBlobsV1 request

closes #18668

Comment thread crates/rpc/rpc-engine-api/src/engine_api.rs Outdated
@mattsse mattsse added the E-osaka Related to the Osaka network upgrade label Sep 24, 2025
Comment thread crates/storage/storage-api/src/block.rs Outdated
Signed-off-by: Delweng <delweng@gmail.com>
Signed-off-by: Delweng <delweng@gmail.com>
Copy link
Copy Markdown
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, easier than fetching the block indeed

Comment on lines +803 to +805
// Check if Osaka fork is active
let current_timestamp =
SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap_or_default().as_secs();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense imo, since this endpoint is only useful for the live chain we can use the system timestamp here

@github-project-automation github-project-automation Bot moved this from Backlog to In Progress in Reth Tracker Sep 26, 2025
@mattsse mattsse merged commit 597fa73 into paradigmxyz:main Sep 26, 2025
39 of 41 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Reth Tracker Sep 26, 2025
shekhirin pushed a commit that referenced this pull request Sep 30, 2025
Signed-off-by: Delweng <delweng@gmail.com>
theochap pushed a commit to theochap/reth that referenced this pull request Oct 13, 2025
Signed-off-by: Delweng <delweng@gmail.com>
Vui-Chee added a commit to okx/reth that referenced this pull request Nov 3, 2025
* dev: (166 commits)
  chore: bump 1.8.3 (paradigmxyz#19379)
  chore: bump alloy-evm 0.21.3
  chore: bump alloy 1.0.37 (paradigmxyz#18795)
  chore: bump version to 1.8.2 (paradigmxyz#18792)
  fix(rpc/engine): check osaka in getBlobsV1 (paradigmxyz#18669)
  fix: remove cancun check (paradigmxyz#18787)
  fix(rpc): fix eth_config impl (paradigmxyz#18744)
  feat: make more EVM and RPC conversions fallible (paradigmxyz#18685)
  chore: bump rust to edition 2024 (paradigmxyz#18692)
  chore: release 1.8.1 (paradigmxyz#18646)
  fix: Revert "chore: disable fee charge in env" (paradigmxyz#18645)
  chore(deps): bump CodSpeedHQ/action from 3 to 4 (paradigmxyz#18333)
  chore: update voc.config.to text to v1.8.0 (paradigmxyz#18644)
  chore: update version to 1.8.0 in Cargo.toml (paradigmxyz#18638)
  fix: check request gas limit before (paradigmxyz#18639)
  chore(observability): add tokio runtime with custom thread naming (paradigmxyz#18635)
  docs: update dashboard table and rpc urls (paradigmxyz#18637)
  feat: add osaka+bpo timestamps (paradigmxyz#18627)
  chore: disable fee charge in env (paradigmxyz#18634)
  chore: bump inspectors 0.30 (paradigmxyz#18633)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E-osaka Related to the Osaka network upgrade

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

return unsupported fork on getblobsv1 after osaka

2 participants