add inner spacing to inline objects (non-empty) - BREAKING#68
Open
brody2consult wants to merge 1 commit intopappasam:mainfrom
Open
add inner spacing to inline objects (non-empty) - BREAKING#68brody2consult wants to merge 1 commit intopappasam:mainfrom
brody2consult wants to merge 1 commit intopappasam:mainfrom
Conversation
brody2consult
commented
Jan 5, 2024
Author
brody2consult
left a comment
There was a problem hiding this comment.
I think the multi-line object formatting could use some improvement:
- closing curly-brace should be out-dented on the next line
- should start a new line after the opening curly-brace
- should be able to add trailing comma after closing curly-brace, in a similar style to using
--trailing-comma-inline-arraywith inline arrays, for multi-line case only
But this is not a high-priority for me, single-line object formatting with the proposed inner spacing is what I care about at this point.
Thanks in advance for the consideration.
brody2consult
pushed a commit
to brody2consult/pretty-toml-sort
that referenced
this pull request
Jan 7, 2024
includes pappasam/toml-sort#68 - add inner spacing to inline objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this would be much cleaner. I would be happy to make this optional (my time permitting), if needed.
example from
tests/examples/sorted/inline-default.toml:multi-line example from
tests/examples/sorted/inline-default.toml:NOTE that I would personally care the most about the single-line object case, no need for multi-line object formatting in my work at this point.