Conversation
tgolsson
approved these changes
Jun 4, 2024
Contributor
tgolsson
left a comment
There was a problem hiding this comment.
Nice! I'm not sure about the commits disappearing, I've not touched those repos since I added the patches.
Contributor
Author
|
Weird! Maybe this won't fix the issue in #20997, but I imagine it can't hurt. |
WorkerPants
pushed a commit
that referenced
this pull request
Jun 4, 2024
These dependencies were using a git dependency due to unmerged bug-fixes. These fixes have now been merged and are available in the latest releases: - console-rs/console#186 - console-rs/indicatif#608 In addition, I think the commits in question may've disappeared? E.g. the fresh build on the new CI platform in had this error: #20997 ``` Updating git repository `https://github.com/tgolsson/console.git` error: failed to load source for dependency `console` Caused by: Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809 Caused by: revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3) ``` Thus, this is marked for cherry-picking back to our active branches.
WorkerPants
pushed a commit
that referenced
this pull request
Jun 4, 2024
These dependencies were using a git dependency due to unmerged bug-fixes. These fixes have now been merged and are available in the latest releases: - console-rs/console#186 - console-rs/indicatif#608 In addition, I think the commits in question may've disappeared? E.g. the fresh build on the new CI platform in had this error: #20997 ``` Updating git repository `https://github.com/tgolsson/console.git` error: failed to load source for dependency `console` Caused by: Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809 Caused by: revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3) ``` Thus, this is marked for cherry-picking back to our active branches.
huonw
added a commit
that referenced
this pull request
Jun 5, 2024
These dependencies were using a git dependency due to unmerged bug-fixes. These fixes have now been merged and are available in the latest releases: - console-rs/console#186 - console-rs/indicatif#608 In addition, I think the commits in question may've disappeared? E.g. the fresh build on the new CI platform in had this error: #20997 ``` Updating git repository `https://github.com/tgolsson/console.git` error: failed to load source for dependency `console` Caused by: Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809 Caused by: revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3) ``` Thus, this is marked for cherry-picking back to our active branches. Co-authored-by: Huon Wilson <huon@exoflare.io>
huonw
added a commit
that referenced
this pull request
Jun 5, 2024
These dependencies were using a git dependency due to unmerged bug-fixes. These fixes have now been merged and are available in the latest releases: - console-rs/console#186 - console-rs/indicatif#608 In addition, I think the commits in question may've disappeared? E.g. the fresh build on the new CI platform in had this error: #20997 ``` Updating git repository `https://github.com/tgolsson/console.git` error: failed to load source for dependency `console` Caused by: Unable to update https://github.com/tgolsson/console.git?rev=5483880905f384679d322e83c37180f122951995#54838809 Caused by: revspec '5483880905f384679d322e83c37180f122951995' not found; class=Reference (4); code=NotFound (-3) ``` Thus, this is marked for cherry-picking back to our active branches. Co-authored-by: Huon Wilson <huon@exoflare.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These dependencies were using a git dependency due to unmerged bug-fixes. These fixes have now been merged and are available in the latest releases:
out.as_raw_fd()to get size inunix_termconsole-rs/console#186real_lenconsole-rs/indicatif#608In addition, I think the commits in question may've disappeared? E.g. the fresh build on the new CI platform in had this error: #20997
Thus, this is marked for cherry-picking back to our active branches.