This repository was archived by the owner on Jun 23, 2020. It is now read-only.
Merged
Conversation
I had to change a logged error to a process exit to make the test fail. Someone with a better understanding of JarJar's rules and test suite could no doubt craft a test that will continue to guard against the problem without this.
This is enough to make the failing test in the previous commit work.
In the same spirit as the previous commit, but without a test case do motivate the changes.
This will render the test case for the keep rule in JavaVersionsTest unable to detect regressions that lead to an exception in ASM bytecode processing.
Member
|
Thanks! Merged. I'll do a release shortly. |
Member
|
@retronym : The |
retronym
added a commit
to retronym/scala
that referenced
this pull request
May 16, 2016
- Intercept incorrect "binary conflict" warning issued by SBT.
Fixes scala/scala-dev#100
- Bump to a new version of pantsbuild/jarjar to fix an
incompatibility with Java 8 parameter names in class
files, which we run into on the 2.12.x branch. See:
pantsbuild/jarjar#19
- Disable info level logging for dependency resolve/download.
milessabin
pushed a commit
to typelevel/scala
that referenced
this pull request
Aug 17, 2016
- Intercept incorrect "binary conflict" warning issued by SBT.
Fixes scala/scala-dev#100
- Bump to a new version of pantsbuild/jarjar to fix an
incompatibility with Java 8 parameter names in class
files, which we run into on the 2.12.x branch. See:
pantsbuild/jarjar#19
- Disable info level logging for dependency resolve/download.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative submission to #18 that tries to test
drive the change.
Some more finesse is needed to make the test case fail
without the
System.exitinKeepProcessor.