feat(webcomponent): add <overtype-editor> custom element with Shadow DOM#40
Merged
panphora merged 5 commits intopanphora:mainfrom Nov 3, 2025
Merged
feat(webcomponent): add <overtype-editor> custom element with Shadow DOM#40panphora merged 5 commits intopanphora:mainfrom
panphora merged 5 commits intopanphora:mainfrom
Conversation
Closed
panphora
added a commit
that referenced
this pull request
Nov 3, 2025
Changes made to prepare PR #40 for merge: - Remove .prettierrc file (unrelated to web components, belongs in Issue #59) - Move web component documentation to dedicated docs/WEB-COMPONENT.md file - Update README.md with concise web component section linking to full docs - Remove dist/overtype.d.ts (should not be in version control) This keeps the PR focused on the web component feature and improves documentation organization. Web component implementation and tests remain unchanged and fully functional (100% test pass rate).
panphora
added a commit
that referenced
this pull request
Nov 3, 2025
Successfully merged web component feature from ChasLui with clean integration: Features added: - Native <overtype-editor> custom element with Shadow DOM - 15 reactive HTML attributes for declarative configuration - Complete JavaScript API (getValue, setValue, getHTML, etc.) - 4 custom events (change, keydown, ready, error) - Framework integration support (React, Vue, Angular) - Separate build artifacts (overtype-webcomponent.js/min/esm) Documentation: - Added concise Web Component section to README - Created comprehensive docs/WEB-COMPONENT.md - Added webcomponent.html example Testing: - Added webcomponent.test.js with 100% test coverage - All 178 tests passing (including TypeScript definitions) - Build sizes: Web Component 93KB minified This merge used a clean extraction strategy to avoid conflicts: 1. Extracted ChasLui changes to tmp/ files 2. Reset conflicted files to main branch state 3. Selectively applied only necessary changes 4. Rebuilt all dist files from clean source
Owner
|
Thank you @ChasLui for this excellent web component implementation! This is in v2.0. Applied with minor improvements:
The Shadow DOM encapsulation and declarative API are great additions. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Motivation
Enable a first-class Web Component for simpler, framework-agnostic integration and style isolation via Shadow DOM, matching the proposed usage in the issue.
Summary of Changes
<overtype-editor>with Shadow DOMdist/overtype-webcomponent.jsdist/overtype-webcomponent.esm.jsdist/overtype-webcomponent.min.jssrc/overtype-webcomponent.jsexamples/webcomponent.htmltest/webcomponent.test.jsUsage
Attributes, Events, Methods
value: initial Markdowntheme: theme name (reuses existing themes)preview: enable preview mode (optional)change: emits{ detail: { value } }on content updatesready: emitted when initializedgetValue(),setValue(value),focus(), etc., aligned with existing APICompatibility
Overtypeusagethemes.jsTesting and Validation
test/webcomponent.test.jscovers render, attribute sync, and event emissionexamples/webcomponent.html(initial value, theme switching, change propagation)Documentation
Follow-ups
focus,blur,selectionChange)attributeChangedCallbackChecklist
<overtype-editor>with Shadow DOM#30(reference)Summary by cubic
Adds a first-class Web Component with Shadow DOM for clean, framework-agnostic embedding while keeping the existing OverType API intact. Implements the behavior requested in issue #30, including attribute-based config and event hooks.
New Features
Bug Fixes