Define an interface for Codefmt#1
Merged
panglesd merged 3 commits intopanglesd:format-long-signature-with-formatfrom Nov 23, 2021
Merged
Define an interface for Codefmt#1panglesd merged 3 commits intopanglesd:format-long-signature-with-formatfrom
panglesd merged 3 commits intopanglesd:format-long-signature-with-formatfrom
Conversation
with an abstract type t. Will be useful for the following changes.
The generator is no longer aware that Codefmt is implemented using closures. Generator code can no longer execute in during rendering.
Owner
|
Looks better indeed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface is defined in such a way that the "generating" (
Generator) code and the "rendering" (Codefmt.render) code don't call each other. The use ofFormatis entirely abstracted, making the interface a lot easier to use.This allows, for example, to add a "state" argument to
Codefmt.t(I tried something here but it didn't end well)