Skip to content

DEPR offsets: rename 'Q' to 'QE'#55553

Merged
MarcoGorelli merged 19 commits intopandas-dev:mainfrom
natmokval:rename-Q-QE-for-offsets
Oct 24, 2023
Merged

DEPR offsets: rename 'Q' to 'QE'#55553
MarcoGorelli merged 19 commits intopandas-dev:mainfrom
natmokval:rename-Q-QE-for-offsets

Conversation

@natmokval
Copy link
Copy Markdown
Contributor

@natmokval natmokval commented Oct 16, 2023 •
edited
Loading

xref #9586, #52064

Deprecated the alias denoting quarter end frequency "Q" for offsets in favour of "QE".

@natmokval natmokval marked this pull request as ready for review October 19, 2023 21:30
@natmokval natmokval added Deprecate Functionality to remove in pandas Frequency DateOffsets labels Oct 20, 2023
@natmokval
Copy link
Copy Markdown
Contributor Author

natmokval commented Oct 20, 2023

@MarcoGorelli, could you please take a look at this PR? It's a follow-up of PR: "DEPR offsets: rename 'M' to 'ME'".
seems like ci failure isn't related to my changes

MarcoGorelli
MarcoGorelli reviewed Oct 20, 2023
View reviewed changes
Comment thread pandas/tests/indexes/datetimes/methods/test_to_period.py Outdated

rng = date_range("01-Jan-2012", periods=8, freq=freq)
prng = rng.to_period()
with tm.assert_produces_warning(UserWarning, match=msg):
Copy link
Copy Markdown
Member

@MarcoGorelli MarcoGorelli Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I'd missed this last time, but this should be FutureWarning, not UserWarning #52064 (review)

could we address that in a separate PR please?

Copy link
Copy Markdown
Contributor Author

@natmokval natmokval Oct 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I corrected Warning class and made the separate PR #55636

Comment thread pandas/tests/indexes/period/test_period_range.py Outdated
Comment on lines +164 to +165
def test_my(self):
Period("2017Q1", freq="Q")
Copy link
Copy Markdown
Member

@MarcoGorelli MarcoGorelli Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporary test name?😉

Comment thread pandas/tests/scalar/period/test_period.py
@natmokval natmokval mentioned this pull request Oct 22, 2023
Merged
MarcoGorelli
MarcoGorelli reviewed Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just this part isn't totally clear to me https://github.com/pandas-dev/pandas/pull/55553/files#r1367138011

Comment thread doc/source/whatsnew/v2.2.0.rst Outdated
Comment on lines +235 to +236
Deprecate alias ``Q`` in favour of ``QE`` for offsets
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Copy link
Copy Markdown
Member

@MarcoGorelli MarcoGorelli Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very similar to the previous section, perhaps we can combine them?

Copy link
Copy Markdown
Contributor Author

@natmokval natmokval Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I agree. I combined these two sections together.

Comment thread pandas/io/json/_table_schema.py Outdated
Comment on lines +211 to +212
# GH#9586 rename frequency M to ME for offsets
field["freq"] = freq_to_period_freqstr(1, field["freq"])
Copy link
Copy Markdown
Member

@MarcoGorelli MarcoGorelli Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left over from #55581 (review)? should we wait for that one to be resolved first?

Copy link
Copy Markdown
Contributor Author

@natmokval natmokval Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it' related to #55581. I agree, it's better at first to merge #55581. I rolled my changes in pandas/io/json/_table_schema.py back , but now I have failures in test_read_json_table_period_orient, which will be resolved after merging.

MarcoGorelli
MarcoGorelli approved these changes Oct 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, should be good on green!

Comment thread pandas/tests/scalar/period/test_period.py
@MarcoGorelli
Copy link
Copy Markdown
Member

MarcoGorelli commented Oct 24, 2023

looks like there's some test failures

 FAILED pandas/tests/io/json/test_json_table_schema.py::TestTableOrientReader::test_read_json_table_period_orient[vals0-None] - TypeError: data type 'period[QE-DEC]' not understood

@natmokval
Copy link
Copy Markdown
Contributor Author

natmokval commented Oct 24, 2023

looks like there's some test failures

 FAILED pandas/tests/io/json/test_json_table_schema.py::TestTableOrientReader::test_read_json_table_period_orient[vals0-None] - TypeError: data type 'period[QE-DEC]' not understood

test_read_json_table_period_orient failed because there was a bug for conversion JSON field descriptor into pandas type for deprecated offsets frequency 'M'. We fixed it in #55581, now the test passes.

I added parameters 'Q' and '2Q' into parametrization of test_read_json_table_orient_period_depr_freq

@MarcoGorelli
Copy link
Copy Markdown
Member

MarcoGorelli commented Oct 24, 2023

thanks @natmokval !

@MarcoGorelli MarcoGorelli merged commit e0a8443 into pandas-dev:main Oct 24, 2023
@github-actions github-actions Bot mentioned this pull request Oct 24, 2023
Closed
@natmokval natmokval mentioned this pull request Oct 26, 2023
Merged
@spencerkclark spencerkclark mentioned this pull request Oct 31, 2023
Closed
@natmokval natmokval mentioned this pull request Nov 4, 2023
Closed
3 tasks
@natmokval natmokval mentioned this pull request Nov 15, 2023
Merged
@mathause mathause mentioned this pull request Jan 16, 2024
Closed
@natmokval natmokval mentioned this pull request Mar 25, 2024
Merged
tacaswell added a commit to tacaswell/pandas that referenced this pull request May 29, 2024
@tacaswell
DOC: Do not list deprecated aliases in docs
2a764de 
The PRs pandas-dev#55792 (Y), pandas-dev#52064 (Q), and pandas-dev#55553 (M) deprecated the single letter
version of the aliases in favour of the -end version of them.

This table was missed as part of that work.
@tacaswell tacaswell mentioned this pull request May 29, 2024
Merged
5 tasks
tacaswell added a commit to tacaswell/pandas that referenced this pull request May 29, 2024
@tacaswell
DOC: Add note about alias deprecations
b4d40a2 
The PRs pandas-dev#55792 (Y), pandas-dev#52064 (Q), and pandas-dev#55553 (M) deprecated the single letter
version of the aliases in favour of the -end version of them.

Add a note to the offset table about deprecations.
MarcoGorelli pushed a commit that referenced this pull request May 31, 2024
@tacaswell
DOC: Add note about deprecated offset aliases (#58861)
5e97237 
DOC: Add note about alias deprecations

The PRs #55792 (Y), #52064 (Q), and #55553 (M) deprecated the single letter
version of the aliases in favour of the -end version of them.

Add a note to the offset table about deprecations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Deprecate Functionality to remove in pandas Frequency DateOffsets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@natmokval @MarcoGorelli