Add back __array_wrap__ for dask compatibility by jorisvandenbossche · Pull Request #45451 · pandas-dev/pandas

jorisvandenbossche · 2022-01-18T16:13:49Z

xref https://github.com/pandas-dev/pandas/pull/44006/files#r786627658

jbrockmendel · 2022-01-18T17:48:35Z

pandas/tests/base/test_misc.py

+    # (https://github.com/dask/dask/issues/8580).
+    # This test is a small dummy ensuring coverage
+    orig = Series([1, 2, 3], index=["a", "b", "c"])
+    result = orig.__array_wrap__(np.array([2, 4, 6]))


is there an actual use case where this gets called organically?

I suppose only with old numpy? (not really an idea though) But so in dask's case they are calling it explicitly / manually (like this test does)

then wouldn't the reasonable thing to do be either a) see if they really need to call it or b) add a "real" test in test_downstream?

see if they really need to call it

They don't need to, and are already fixing it (but we should still do this PR to not directly break released dask IMO, and I can open an issue to remove it in a year or so, or we can first deprecate it)

add a "real" test in test_downstream?

I would say that the "real" test is downstream in dask's test suite :)
In the end I don't really care where the test is put, but I think putting it here without usage of dask is useful (I think the dowstream tests are much easier to miss while developing)

Added a downstream dask test, but also kept this one.

Will do a follow-up PR to add a deprecation warning for 1.5

Sounds good.

Follow-up PR to deprecate it -> #45517

jreback · 2022-01-19T14:54:59Z

lots of things failing here, can you merge master

jreback · 2022-01-19T18:06:48Z

pandas/tests/test_downstream.py

        pd.set_option("compute.use_numexpr", olduse)


+@pytest.mark.filterwarnings("ignore:.*64Index is deprecated:FutureWarning")


can you use the import decorator here e.g. @td.skip_if_no("xarray" (and can you fix the L39 one

i also don't know why we have a special import_module here.

This seems to be done on purpose:

pandas/pandas/tests/test_downstream.py

Lines 23 to 30 in 4ce84de

def import_module(name):

# we *only* want to skip if the module is truly not available

# and NOT just an actual import error because of pandas changes

try:

return importlib.import_module(name)

except ModuleNotFoundError:

pytest.skip(f"skipping as {name} not available")

ok really this should be cleaned up cc @jbrockmendel

jreback · 2022-01-20T13:46:38Z

@meeseeksdev backport 1.4.x

…ibility

lumberbot-app · 2022-01-20T13:47:15Z

Something went wrong ... Please have a look at my logs.

…45491) Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

jorisvandenbossche added 2 commits January 18, 2022 17:06

restore array_wrap

ddd2f84

add comment / test

f52f041

jorisvandenbossche added this to the 1.4 milestone Jan 18, 2022

jorisvandenbossche requested a review from jbrockmendel January 18, 2022 16:13

jbrockmendel reviewed Jan 18, 2022

View reviewed changes

jreback added the Compat pandas objects compatability with Numpy or Python functions label Jan 18, 2022

jorisvandenbossche added 2 commits January 19, 2022 09:00

Merge remote-tracking branch 'upstream/main' into array-wrap

49aa716

add dask downstream test

c4bc2eb

fix dtype in test

f90d849

jreback reviewed Jan 19, 2022

View reviewed changes

jreback merged commit 04f5721 into pandas-dev:main Jan 20, 2022

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 20, 2022

Backport PR pandas-dev#45451: Add back __array_wrap__ for dask compat…

218cf3b

…ibility

meeseeksmachine mentioned this pull request Jan 20, 2022

Backport PR #45451 on branch 1.4.x (Add back __array_wrap__ for dask compatibility) #45491

Merged

jreback pushed a commit that referenced this pull request Jan 20, 2022

Backport PR #45451: Add back __array_wrap__ for dask compatibility (#…

cefb74c

…45491) Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

jorisvandenbossche deleted the array-wrap branch January 21, 2022 07:16

This was referenced Jan 21, 2022

DEPR: __array_wrap__ #45517

Merged

Return da.Array rather than dd.Series for non-ufunc elementwise functions on dd.Series dask/dask#8558

Merged

		pd.set_option("compute.use_numexpr", olduse)


		@pytest.mark.filterwarnings("ignore:.*64Index is deprecated:FutureWarning")

	def import_module(name):
	# we only want to skip if the module is truly not available
	# and NOT just an actual import error because of pandas changes

	try:
	return importlib.import_module(name)
	except ModuleNotFoundError:
	pytest.skip(f"skipping as {name} not available")

Uh oh!

Conversation

jorisvandenbossche commented Jan 18, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jreback commented Jan 19, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jreback commented Jan 20, 2022

Uh oh!

lumberbot-app bot commented Jan 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants