Skip to content

Fix typo in docstring of DataFrame.memory_usage#25761

Merged
WillAyd merged 2 commits intopandas-dev:0.24.xfrom
pjleimbigler:patch-1
Mar 18, 2019
Merged

Fix typo in docstring of DataFrame.memory_usage#25761
WillAyd merged 2 commits intopandas-dev:0.24.xfrom
pjleimbigler:patch-1

Conversation

@pjleimbigler
Copy link
Copy Markdown
Contributor

@pjleimbigler pjleimbigler commented Mar 18, 2019

No description provided.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Mar 18, 2019 •
edited
Loading

Hello @pjleimbigler! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2525:77: W291 trailing whitespace

Comment last updated at 2019-03-18 03:55:50 UTC

@WillAyd
Copy link
Copy Markdown
Member

WillAyd commented Mar 18, 2019

Can you address the PEP8 violation?

WillAyd
WillAyd requested changes Mar 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment above

@WillAyd WillAyd added the Docs label Mar 18, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Mar 18, 2019
@pjleimbigler
Fix PEP8 line length violation
c4e48f0 
Rewrap line 2525 of frame.py (the docstring of `DataFrame.memory_usage`) to conform with PEP8 line length.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2019

Codecov Report

Merging #25761 into 0.24.x will decrease coverage by 49.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           0.24.x   #25761       +/-   ##
===========================================
- Coverage   92.39%   42.91%   -49.49%     
===========================================
  Files         166      166               
  Lines       52430    52430               
===========================================
- Hits        48443    22499    -25944     
- Misses       3987    29931    +25944
Flag Coverage Δ
#multiple ?
#single 42.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 35.59% <ø> (-61.28%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.35%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc9051...c4e48f0. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2019 •
edited
Loading

Codecov Report

Merging #25761 into 0.24.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25761      +/-   ##
==========================================
- Coverage   92.39%   92.39%   -0.01%     
==========================================
  Files         166      166              
  Lines       52430    52430              
==========================================
- Hits        48443    48442       -1     
- Misses       3987     3988       +1
Flag Coverage Δ
#multiple 90.83% <ø> (ø) ⬆️
#single 42.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 96.86% <ø> (ø) ⬆️
pandas/util/testing.py 88.04% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc9051...c4e48f0. Read the comment docs.

@pjleimbigler
Copy link
Copy Markdown
Contributor Author

pjleimbigler commented Mar 18, 2019

Apologies; rewrapped the offending line in a new commit (c4e48f0).

@WillAyd WillAyd merged commit aaec051 into pandas-dev:0.24.x Mar 18, 2019
@WillAyd
Copy link
Copy Markdown
Member

WillAyd commented Mar 18, 2019

Thanks!

WillAyd added a commit that referenced this pull request Mar 18, 2019
@WillAyd
Revert "Fix typo in docstring of DataFrame.memory_usage (#25761)"
e392ee5 
This reverts commit aaec051.
@pjleimbigler pjleimbigler deleted the patch-1 branch March 18, 2019 14:16
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Mar 19, 2019
@pjleimbigler @WillAyd
Fix typo in docstring of DataFrame.memory_usage (pandas-dev#25761)
1e9e379
@WillAyd WillAyd mentioned this pull request Mar 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

0.25.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pjleimbigler @pep8speaks @WillAyd