ENH: Expose symlog scaling in plotting API by charlesdong1991 · Pull Request #24968 · pandas-dev/pandas

charlesdong1991 · 2019-01-27T22:20:37Z

closes ENH: Expose symlog scaling in plotting API #24867
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

charlesdong1991 · 2019-01-27T22:43:04Z

I am very very sorry that i made some git mistakes in my preivous PR, so i closed it and reopen this one.
And this one is based on the review from @jreback. #24871
Will appreciate a lot for further feedbacks.

codecov · 2019-01-27T22:55:53Z

Codecov Report

Merging #24968 into master will decrease coverage by 49.49%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #24968      +/-   ##
==========================================
- Coverage   92.38%   42.88%   -49.5%     
==========================================
  Files         166      166              
  Lines       52398    52406       +8     
==========================================
- Hits        48406    22476   -25930     
- Misses       3992    29930   +25938

Flag	Coverage Δ
#multiple	`?`
#single	`42.88% <0%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/plotting/_core.py	`17.68% <0%> (-65.9%)`	⬇️
pandas/io/formats/latex.py	`0% <0%> (-100%)`	⬇️
pandas/core/categorical.py	`0% <0%> (-100%)`	⬇️
pandas/io/sas/sas_constants.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/plotting.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/converter.py	`0% <0%> (-100%)`	⬇️
pandas/io/formats/html.py	`0% <0%> (-99.35%)`	⬇️
pandas/core/groupby/categorical.py	`0% <0%> (-95.46%)`	⬇️
pandas/io/sas/sas7bdat.py	`0% <0%> (-91.17%)`	⬇️
pandas/io/sas/sas_xport.py	`0% <0%> (-90.15%)`	⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b16e2e...f1c86af. Read the comment docs.

codecov · 2019-01-27T22:55:53Z

Codecov Report

Merging #24968 into master will increase coverage by 0.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master   #24968      +/-   ##
==========================================
+ Coverage   91.45%   91.47%   +0.01%     
==========================================
  Files         172      173       +1     
  Lines       52892    52883       -9     
==========================================
+ Hits        48373    48375       +2     
+ Misses       4519     4508      -11

Flag	Coverage Δ
#multiple	`90.03% <75%> (+0.01%)`	⬆️
#single	`41.8% <0%> (-0.02%)`	⬇️

Impacted Files	Coverage Δ
pandas/plotting/_core.py	`83.57% <75%> (-0.09%)`	⬇️
pandas/io/packers.py	`88.11% <0%> (-0.11%)`	⬇️
pandas/core/panel.py	`35.62% <0%> (-0.1%)`	⬇️
pandas/io/formats/printing.py	`85.34% <0%> (-0.08%)`	⬇️
pandas/io/pytables.py	`90.19% <0%> (-0.01%)`	⬇️
pandas/io/formats/format.py	`97.99% <0%> (ø)`	⬆️
pandas/io/formats/latex.py	`100% <0%> (ø)`	⬆️
pandas/core/indexes/interval.py	`95.25% <0%> (ø)`	⬆️
pandas/core/indexes/multi.py	`95.62% <0%> (ø)`	⬆️
pandas/core/api.py	`100% <0%> (ø)`	⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0f9a9...5170000. Read the comment docs.

jreback · 2019-01-29T13:07:25Z

doc/source/whatsnew/v0.25.0.rst

-
-
-
+:func:`DataFrame.plot` allows to expose symlog scaling for axis.


can you make this more informative, something like
DataFrame.plot keyword logy and logx now accept the value sym to .....

add the issue number (or if not issue, this PR number)

thanks for the review, changed! @jreback

jreback · 2019-01-29T13:08:12Z

pandas/plotting/_core.py

        axes = _flatten(axes)

-        if self.logx or self.loglog:
+        valid_log = [False, True, 'sym', None]


use a set comprehension to check

doc/source/whatsnew/v0.25.0.rst

pandas/plotting/_core.py

pandas/tests/plotting/test_frame.py

charlesdong1991 · 2019-02-28T20:01:10Z

can anyone give a feedback? ^^

TomAugspurger

Couple minor comments. LGTM otherwise.

TomAugspurger · 2019-03-05T15:39:51Z

doc/source/whatsnew/v0.25.0.rst

 ^^^^^^^^^^^^^^^^^^

+
+- :func:`DataFrame.plot` keywords ``logy``, ``logx`` and ``loglog`` can now accept the value ``sym`` for symlog scaling. (:issue:`24867`)


Put sym in quotes, like ``'sim'``

TomAugspurger · 2019-03-05T15:41:53Z

pandas/plotting/_core.py

+        valid_log = {False, True, 'sym', None}
+        input_log = {self.logx, self.logy, self.loglog}
+        if input_log - valid_log:
+            raise ValueError("Valid inputs are boolean, None and 'sym'.")


Capture the bad parameter values and include them in the error message.

thanks, changed! @TomAugspurger

TomAugspurger · 2019-03-05T17:10:33Z

pandas/plotting/_core.py

+        valid_log = {False, True, 'sym', None}
+        input_log = {self.logx, self.logy, self.loglog}
+        if input_log - valid_log:
+            raise ValueError(f"Valid inputs are boolean, None and 'sym'"


We can't use f-strings yet, unfortunately.

sorry, changed! thanks! @TomAugspurger

May need to push these changes.

ahh, i am really really sorry... i thought i successfully pushed the change before rushing home @TomAugspurger

TomAugspurger · 2019-03-05T17:11:20Z

pandas/tests/plotting/test_frame.py

+        # GH: 24867
+        df = DataFrame({'a': np.arange(100)}, index=np.arange(100))
+
+        msg = "Valid inputs are boolean, None and 'sym'"


Can you update the match msg to ensure that the bad parameter is included. You can remove the "wrong_input" fixture I think, and just test one bad input.

WillAyd

Can you address merge conflict?

WillAyd · 2019-03-19T03:53:47Z

pandas/tests/plotting/test_frame.py

+
        ax = df.plot(logy=True)
        self._check_ax_scales(ax, yaxis='log')
+        assert ax.get_yscale() == 'log'


Rather than these individual checks can you parametrize all of the combinations?

thanks! @WillAyd i parametrize the combinations.

pandas/tests/plotting/test_frame.py

pandas/plotting/_core.py

charlesdong1991 · 2019-03-24T15:18:19Z

@TomAugspurger Hi, Tom, I checked your comment in #25586 and made some small changes and modified the tests to align it, feel free to provide your feedback.

jreback

small doc comments

jreback · 2019-03-24T23:40:08Z

pandas/plotting/_core.py

+    logx : bool or 'sym', default False
+        Use log scaling or symlog scaling on x axis
+        .. versionadded:: 0.25.0
+    logy : bool or 'sym' default False


need a blank line after the versionadded (for each of these); make these versionchanged

pandas/tests/plotting/test_frame.py

jreback · 2019-03-30T19:26:15Z

@TomAugspurger a quick look if you can.

WillAyd

lgtm as well

jreback · 2019-04-12T11:54:26Z

thanks @charlesdong1991

charlesdong1991 force-pushed the issue_backupbackup branch from be9e0bd to 2b18113 Compare January 27, 2019 22:27

jreback requested changes Jan 29, 2019

View reviewed changes

jschendel added Enhancement Visualization plotting labels Jan 29, 2019

jschendel reviewed Jan 29, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

jschendel reviewed Jan 29, 2019

View reviewed changes

pandas/plotting/_core.py Outdated Show resolved Hide resolved

jschendel reviewed Jan 29, 2019

View reviewed changes

pandas/tests/plotting/test_frame.py Outdated Show resolved Hide resolved

TomAugspurger added this to the 0.25.0 milestone Mar 5, 2019

TomAugspurger reviewed Mar 5, 2019

View reviewed changes

merge master

88705a5

charlesdong1991 force-pushed the issue_backupbackup branch from d7363a7 to 88705a5 Compare March 5, 2019 17:04

charlesdong1991 added 2 commits March 5, 2019 18:05

add quote

7bf16e4

change error message

446bcc0

TomAugspurger reviewed Mar 5, 2019

View reviewed changes

charlesdong1991 added 5 commits March 5, 2019 18:16

change test

238d1f4

optimize

8941bdf

push change

f8b124a

fix test error

549dd4d

fix tests

0ea6653

TomAugspurger mentioned this pull request Mar 7, 2019

BUG: secondary y axis could not be set to log scale (#25545) #25586

Merged

4 tasks

WillAyd requested changes Mar 19, 2019

View reviewed changes

jreback reviewed Mar 19, 2019

View reviewed changes

pandas/plotting/_core.py Show resolved Hide resolved

charlesdong1991 added 3 commits March 24, 2019 15:41

fix conflict

8b9ede1

add docstring

3a265e9

parametrize tests

a3e71c9

charlesdong1991 added 2 commits March 24, 2019 16:13

xref 25586

9c205f5

add testing

d0e5c41

jreback requested changes Mar 24, 2019

View reviewed changes

add blank line after version change

5170000

jreback approved these changes Mar 30, 2019

View reviewed changes

WillAyd approved these changes Apr 10, 2019

View reviewed changes

jreback merged commit 03a0948 into pandas-dev:master Apr 12, 2019

yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019

ENH: Expose symlog scaling in plotting API (pandas-dev#24968)

5ed351c

		^^^^^^^^^^^^^^^^^^


		- :func:`DataFrame.plot` keywords ``logy``, ``logx`` and ``loglog`` can now accept the value ``sym`` for symlog scaling. (:issue:`24867`)

Uh oh!

Conversation

charlesdong1991 commented Jan 27, 2019 • edited by WillAyd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charlesdong1991 commented Jan 27, 2019

Uh oh!

codecov bot commented Jan 27, 2019

Codecov Report

Uh oh!

codecov bot commented Jan 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charlesdong1991 commented Feb 28, 2019

Uh oh!

TomAugspurger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WillAyd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charlesdong1991 commented Mar 24, 2019

Uh oh!

jreback left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jreback commented Mar 30, 2019

Uh oh!

WillAyd left a comment

Choose a reason for hiding this comment

Uh oh!

jreback commented Apr 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

charlesdong1991 commented Jan 27, 2019 •

edited by WillAyd

Loading

codecov bot commented Jan 27, 2019 •

edited

Loading