Skip to content

TST: use s3_resource fixture consistently#24073

Merged
jreback merged 2 commits intopandas-dev:masterfrom
h-vetinari:s3_fixture
Dec 4, 2018
Merged

TST: use s3_resource fixture consistently#24073
jreback merged 2 commits intopandas-dev:masterfrom
h-vetinari:s3_fixture

Conversation

@h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Dec 3, 2018

There are two boto tests that are not using the dedicated s3_resource fixture which takes care of all the mocking etc. This PR adapts those tests accordingly, which also allows unified treatment of things like #23754.

@pep8speaks
Copy link

pep8speaks commented Dec 3, 2018

Hello @h-vetinari! Thanks for submitting the PR.

@h-vetinari h-vetinari mentioned this pull request Dec 3, 2018
Merged
2 tasks
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #24073 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24073   +/-   ##
=======================================
  Coverage   42.51%   42.51%           
=======================================
  Files         161      161           
  Lines       51689    51689           
=======================================
  Hits        21974    21974           
  Misses      29715    29715
Flag Coverage Δ
#single 42.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe697f...6526d3f. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #24073 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24073   +/-   ##
=======================================
  Coverage   42.51%   42.51%           
=======================================
  Files         161      161           
  Lines       51689    51689           
=======================================
  Hits        21974    21974           
  Misses      29715    29715
Flag Coverage Δ
#single 42.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe697f...6526d3f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #24073 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24073   +/-   ##
=======================================
  Coverage   42.51%   42.51%           
=======================================
  Files         161      161           
  Lines       51689    51689           
=======================================
  Hits        21974    21974           
  Misses      29715    29715
Flag Coverage Δ
#single 42.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe697f...6526d3f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2018 •
edited
Loading

Codecov Report

Merging #24073 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24073   +/-   ##
=======================================
  Coverage   42.51%   42.51%           
=======================================
  Files         161      161           
  Lines       51689    51689           
=======================================
  Hits        21974    21974           
  Misses      29715    29715
Flag Coverage Δ
#single 42.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe697f...6526d3f. Read the comment docs.

@jreback jreback added Testing pandas testing functions or related to the test suite IO Data IO issues that don't fit into a more specific label labels Dec 4, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 4, 2018
@jreback jreback merged commit b3fc609 into pandas-dev:master Dec 4, 2018
@jreback
Copy link
Contributor

jreback commented Dec 4, 2018

thanks!

@h-vetinari h-vetinari deleted the s3_fixture branch December 4, 2018 07:42
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@h-vetinari @Pingviinituutti
TST: use s3_resource fixture consistently (pandas-dev#24073)
1bac2e0
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@h-vetinari @Pingviinituutti
TST: use s3_resource fixture consistently (pandas-dev#24073)
101b11d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

0.24.0

Development

Successfully merging this pull request may close these issues.

3 participants

@h-vetinari @pep8speaks @jreback