TST: Skip 32bit failing IntervalTree tests#23442
Merged
jreback merged 1 commit intopandas-dev:masterfrom Nov 1, 2018
Merged
Conversation
|
Hello @jschendel! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23442 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 161 161
Lines 51187 51187
=======================================
Hits 47202 47202
Misses 3985 3985
Continue to review full report at Codecov.
|
Contributor
|
thanks! |
Contributor
|
https://travis-ci.org/MacPython/pandas-wheels/jobs/449669142 hmm this is now failing for a different reason .get_indexer should be returning platform int - but it’s not ? (maybe just this case) |
Contributor
|
Hi, I get failures on my 32bit installation when leaf_size=10000. |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #23440, #23353 (comment)
Note that we've been skipping tests due to this issue for some time now, it just wasn't formally documented as an issue:
pandas/pandas/tests/indexes/interval/test_interval_tree.py
Lines 88 to 91 in 9019582
I recently added some new tests that hit this same issue but were not skipped and are now causing the pandas-wheels nightly builds to fail. This PR causes those tests to be skipped on 32bit, and modifies the existing skipped test to skip at the parameter level instead of globally skipping the test (one of the previously skipped parametrized values should be valid on 32bit).