Skip to content

BUG: sets in str.cat#23187

Merged
jreback merged 3 commits intopandas-dev:masterfrom
h-vetinari:str_cat_set
Oct 23, 2018
Merged

BUG: sets in str.cat#23187
jreback merged 3 commits intopandas-dev:masterfrom
h-vetinari:str_cat_set

Conversation

@h-vetinari
Copy link
Copy Markdown
Contributor

@h-vetinari h-vetinari commented Oct 16, 2018

  • closes sets in str.cat?! #23009
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This is split off from #23065.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Oct 16, 2018

Hello @h-vetinari! Thanks for submitting the PR.

@h-vetinari h-vetinari mentioned this pull request Oct 16, 2018
Merged
4 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@4cac923). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23187   +/-   ##
=========================================
  Coverage          ?   92.19%           
=========================================
  Files             ?      169           
  Lines             ?    50956           
  Branches          ?        0           
=========================================
  Hits              ?    46978           
  Misses            ?     3978           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.61% <100%> (?)
#single 42.27% <0%> (?)
Impacted Files Coverage Δ
pandas/core/strings.py 98.58% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cac923...deb912e. Read the comment docs.

@h-vetinari
Copy link
Copy Markdown
Contributor Author

h-vetinari commented Oct 18, 2018

@jreback
Tiny follow-up to / split-off from #23065, all green and ready for review

@jreback jreback added API Design Strings String extension data type and string data labels Oct 19, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 19, 2018
jreback
jreback requested changes Oct 19, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, ping on green.

doc/source/whatsnew/v0.24.0.txt Outdated
^^^^^^^

-
- Bug in :meth:`Series.str.cat` which falsely did not raise if `others` was a `set` (:issue:`23009`)
Copy link
Copy Markdown
Contributor

@jreback jreback Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an api breaking change, so move it there. make this declerative as well, e.g. Series.str.cat will now raise if others is a set

pandas/tests/test_strings.py
s.str.cat([u, [u, d]])

# forbidden input type, e.g. int
# forbidden input type: set
Copy link
Copy Markdown
Contributor

@jreback jreback Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number here

@h-vetinari h-vetinari force-pushed the str_cat_set branch 3 times, most recently from 4a9a94b to f447f05 Compare October 22, 2018 14:18
@jreback jreback merged commit 779aeac into pandas-dev:master Oct 23, 2018
@jreback
Copy link
Copy Markdown
Contributor

jreback commented Oct 23, 2018

thanks!

@h-vetinari h-vetinari deleted the str_cat_set branch October 23, 2018 05:39
jorisvandenbossche added a commit that referenced this pull request Oct 23, 2018
@jorisvandenbossche
Revert "BUG: sets in str.cat (#23187)"
92dbb62 
This reverts commit 779aeac.
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Oct 23, 2018
@h-vetinari @JustinZhengBC
BUG: sets in str.cat (pandas-dev#23187)
e8f35ba
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@h-vetinari @tm9k1
BUG: sets in str.cat (pandas-dev#23187)
fae8130
@h-vetinari h-vetinari mentioned this pull request Jul 26, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback requested changes

Assignees

No one assigned

Labels

API Design Strings String extension data type and string data

Projects

None yet

Milestone

0.24.0

Development

Successfully merging this pull request may close these issues.

sets in str.cat?!

3 participants

@h-vetinari @pep8speaks @jreback