ENH: Add support for tablewise application of style.background_gradient with axis=None by soxofaan · Pull Request #21259 · pandas-dev/pandas

soxofaan · 2018-05-30T15:58:02Z

closes ENH: Allow elementwise coloring in background_gradient with axis=None #15204
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pep8speaks · 2018-05-30T15:58:05Z

Hello @soxofaan! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on July 11, 2018 at 15:48 Hours UTC

jschendel · 2018-05-30T17:07:40Z

pandas/io/formats/style.py

        with _mpl(Styler.background_gradient) as (plt, colors):
-            rng = s.max() - s.min()
+            min = s.values.min()
+            max = s.values.max()


Can you use different names for min/max so they don't override the built-in min/max functions?

sure, updated commit

codecov · 2018-05-30T21:11:49Z

Codecov Report

Merging #21259 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #21259      +/-   ##
==========================================
+ Coverage   91.92%   91.92%   +<.01%     
==========================================
  Files         160      160              
  Lines       49906    49910       +4     
==========================================
+ Hits        45875    45879       +4     
  Misses       4031     4031

Flag	Coverage Δ
#multiple	`90.3% <100%> (ø)`	⬆️
#single	`42.1% <0%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/formats/style.py	`96.16% <100%> (+0.03%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0daa0...c39f420. Read the comment docs.

soxofaan · 2018-05-31T08:26:29Z

@jschendel I updated the commit per your request

the failing tests/checks are not related to the change as far as I understand, is there something I should do about that?

jreback · 2018-05-31T10:09:59Z

you have linting issues:

pandas/tests/io/formats/test_style.py:1066:1: E303 too many blank lines (3)

jreback · 2018-05-31T10:10:31Z

is it worth adding the OP example here?

soxofaan · 2018-05-31T12:56:48Z

@jreback thanks, I didn't catch that linting issue warning. Lot of trees in the forest.

I think the OP example is good for interactive testing, but overkill for unit testing

soxofaan · 2018-05-31T17:28:27Z

(this PR will conflict with #21263 )

soxofaan · 2018-06-07T19:15:15Z

Had to rework this PR because #21263 has been merged

note that making background_gradient compatible with axis=None enabled to simplify the relative_luminance implementation of #21263

soxofaan · 2018-06-07T19:18:54Z

Illustration:

jreback

minor comments. lgtm.

jreback · 2018-06-19T00:59:16Z

doc/source/whatsnew/v0.24.0.txt

 - :func:`to_csv` now supports ``compression`` keyword when a file handle is passed. (:issue:`21227`)
 - :meth:`Index.droplevel` is now implemented also for flat indexes, for compatibility with MultiIndex (:issue:`21115`)
-
+- Allow elementwise coloring in ``style.background_gradient`` with ``axis=None`` (:issue:`15204`)


use :class:`pandas.io.formats.style.Styler`

or even better, I'll move it alongside with the changelog entry for PR #21263

soxofaan · 2018-06-20T07:54:47Z

continuous-integration/travis-ci/pr failure is due to

CondaHTTPError: HTTP 502 BAD GATEWAY for url <https://conda.anaconda.org/conda-forge/linux-64/repodata.json>

soxofaan · 2018-06-20T08:38:48Z

😕 now continuous-integration/travis-ci/pr failure is due to

$ curl -sSf -o python-3.5.tar.bz2 ${archive_url}
curl: (35) Unknown SSL protocol error in connection to s3.amazonaws.com:443 
Unable to download 3.5 archive. The archive may not exist. Please consider a different version.

…nt with axis=None pandas-dev#15204

soxofaan · 2018-07-11T15:48:25Z

(rebased on latest master)

TomAugspurger · 2018-07-12T12:38:39Z

Thanks!

…v#21259)

soxofaan force-pushed the issue-15204-background-axix-none branch 3 times, most recently from 060fd66 to b1dfa6c Compare May 30, 2018 16:06

jschendel reviewed May 30, 2018

View reviewed changes

jschendel added Enhancement Output-Formatting __repr__ of pandas objects, to_string labels May 30, 2018

jschendel added this to the 0.24.0 milestone May 30, 2018

soxofaan force-pushed the issue-15204-background-axix-none branch from b1dfa6c to e376312 Compare May 30, 2018 21:11

soxofaan force-pushed the issue-15204-background-axix-none branch from e376312 to e6f7758 Compare May 31, 2018 00:07

soxofaan mentioned this pull request May 31, 2018

Use light text color on dark colors in style.background_gradient #21269

Closed

soxofaan force-pushed the issue-15204-background-axix-none branch from e6f7758 to 5c05bf1 Compare May 31, 2018 12:55

soxofaan force-pushed the issue-15204-background-axix-none branch from 5c05bf1 to 23a4bfb Compare May 31, 2018 17:00

soxofaan force-pushed the issue-15204-background-axix-none branch from 23a4bfb to 0f2b688 Compare June 7, 2018 19:12

soxofaan mentioned this pull request Jun 7, 2018

Color text based on background color when using _background_gradient() #21263

Merged

4 tasks

soxofaan force-pushed the issue-15204-background-axix-none branch from 0f2b688 to 5322f25 Compare June 8, 2018 07:14

jreback approved these changes Jun 19, 2018

View reviewed changes

soxofaan force-pushed the issue-15204-background-axix-none branch from 5322f25 to f044cf7 Compare June 19, 2018 17:38

soxofaan mentioned this pull request Jun 20, 2018

style.bar: add support for axis=None (tablewise application instead of rowwise or columnwise) #21548

Merged

4 tasks

soxofaan force-pushed the issue-15204-background-axix-none branch from f044cf7 to d615e90 Compare June 20, 2018 07:59

TomAugspurger approved these changes Jun 20, 2018

View reviewed changes

soxofaan mentioned this pull request Jun 20, 2018

background_gradient vmin and vmax #12145

Closed

soxofaan changed the title ~~ENH: Allow elementwise coloring in background_gradient with axis=None~~ ENH: Add support for tablewise application of style.background_gradient with axis=None Jun 24, 2018

ENH: Add support for tablewise application of style.background_gradie…

c39f420

…nt with axis=None pandas-dev#15204

soxofaan force-pushed the issue-15204-background-axix-none branch from d615e90 to c39f420 Compare July 11, 2018 15:47

TomAugspurger merged commit bdb6168 into pandas-dev:master Jul 12, 2018

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018

ENH: tablewise Styler.background_gradient pandas-dev#15204 (pandas-de…

3393765

…v#21259)

joelostblom mentioned this pull request Mar 5, 2019

Document the behavior of axis=None with style.background_gradient #25551

Merged

2 tasks

Uh oh!

Conversation

soxofaan commented May 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented May 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated on July 11, 2018 at 15:48 Hours UTC

Uh oh!

jschendel May 30, 2018

Choose a reason for hiding this comment

Uh oh!

soxofaan May 30, 2018

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

soxofaan commented May 31, 2018

Uh oh!

jreback commented May 31, 2018

Uh oh!

jreback commented May 31, 2018

Uh oh!

soxofaan commented May 31, 2018

Uh oh!

soxofaan commented May 31, 2018

Uh oh!

soxofaan commented Jun 7, 2018

Uh oh!

soxofaan commented Jun 7, 2018

Uh oh!

jreback left a comment

Choose a reason for hiding this comment

Uh oh!

jreback Jun 19, 2018

Choose a reason for hiding this comment

Uh oh!

soxofaan Jun 19, 2018

Choose a reason for hiding this comment

Uh oh!

soxofaan commented Jun 20, 2018

Uh oh!

soxofaan commented Jun 20, 2018

Uh oh!

soxofaan commented Jul 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomAugspurger commented Jul 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

soxofaan commented May 30, 2018 •

edited

Loading

pep8speaks commented May 30, 2018 •

edited

Loading

codecov bot commented May 30, 2018 •

edited

Loading

soxofaan commented Jul 11, 2018 •

edited

Loading