DOC: update the window.Rolling.min docstring#20263
Merged
jorisvandenbossche merged 3 commits intopandas-dev:masterfrom Mar 17, 2018
Merged
DOC: update the window.Rolling.min docstring#20263jorisvandenbossche merged 3 commits intopandas-dev:masterfrom
jorisvandenbossche merged 3 commits intopandas-dev:masterfrom
Conversation
|
Hello @gojandrooo! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on March 17, 2018 at 11:49 Hours UTC |
WillAyd
requested changes
Mar 11, 2018
pandas/core/window.py
Outdated
| with a window size of 3. | ||
|
|
||
| >>> s = pd.Series([4,3,5,2,6]) | ||
| >>> s |
Member
There was a problem hiding this comment.
The constructor here is simple enough that you don't need to explicitly print
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Small comment + @WillAyd 's one, looks good!
pandas/core/window.py
Outdated
| The below example will show a rolling calculation | ||
| with a window size of 3. | ||
|
|
||
| >>> s = pd.Series([4,3,5,2,6]) |
Member
There was a problem hiding this comment.
spaces after comma for PEP8
jorisvandenbossche
approved these changes
Mar 17, 2018
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Pushed a small update fixing the PEP8 issues
Member
|
@gojandrooo Thanks! |
nehiljain
added a commit
to nehiljain/pandas
that referenced
this pull request
Mar 21, 2018
…ame_describe * upstream/master: (158 commits) Add link to "Craft Minimal Bug Report" blogpost (pandas-dev#20431) BUG: fixed json_normalize for subrecords with NoneTypes (pandas-dev#20030) (pandas-dev#20399) BUG: ExtensionArray.fillna for scalar values (pandas-dev#20412) DOC" update the Pandas core window rolling count docstring" (pandas-dev#20264) DOC: update the pandas.DataFrame.plot.hist docstring (pandas-dev#20155) DOC: Only use ~ in class links to hide prefixes. (pandas-dev#20402) Bug: Allow np.timedelta64 objects to index TimedeltaIndex (pandas-dev#20408) DOC: add disallowing of Series construction of len-1 list with index to whatsnew (pandas-dev#20392) MAINT: Remove weird pd file DOC: update the Index.isin docstring (pandas-dev#20249) BUG: Handle all-NA blocks in concat (pandas-dev#20382) DOC: update the pandas.core.resample.Resampler.fillna docstring (pandas-dev#20379) BUG: Don't raise exceptions splitting a blank string (pandas-dev#20067) DOC: update the pandas.DataFrame.cummax docstring (pandas-dev#20336) DOC: update the pandas.core.window.x.mean docstring (pandas-dev#20265) DOC: update the api.types.is_number docstring (pandas-dev#20196) Fix linter (pandas-dev#20389) DOC: Improved the docstring of pandas.Series.dt.to_pytimedelta (pandas-dev#20142) DOC: update the pandas.Series.dt.is_month_end docstring (pandas-dev#20181) DOC: update the window.Rolling.min docstring (pandas-dev#20263) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>git diff upstream/master -u -- "*.py" | flake8 --diffpython doc/make.py --single <your-function-or-method>Please include the output of the validation script below between the "```" ticks:
If the validation script still gives errors, but you think there is a good reason
to deviate in this case (and there are certainly such cases), please state this
explicitly.
Checklist for other PRs (remove this part if you are doing a PR for the pandas documentation sprint):
git diff upstream/master -u -- "*.py" | flake8 --diff