DEPR: deprecate sortlevel in favor of sort_index#15099
Merged
jorisvandenbossche merged 1 commit intopandas-dev:masterfrom Jan 11, 2017
Merged
DEPR: deprecate sortlevel in favor of sort_index#15099jorisvandenbossche merged 1 commit intopandas-dev:masterfrom
jorisvandenbossche merged 1 commit intopandas-dev:masterfrom
Conversation
8 tasks
1 task
jorisvandenbossche
approved these changes
Jan 10, 2017
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Great!
Minor comment.
Apart from that, should we add a basic sortlevel test that tests that a warning is raised and that it gives the same as sort_index?
pandas/core/frame.py
Outdated
| DataFrame.sort_index(level=...) | ||
|
|
||
| """ | ||
| warnings.warn("sortlevel is deprecated, use sort_index(...)", |
Member
There was a problem hiding this comment.
maybe 'sort_index(level=...)' to be a bit more specific?
pandas/core/series.py
Outdated
| Series.sort_index(level=...) | ||
|
|
||
| """ | ||
| warnings.warn("sortlevel is deprecated, use sort_index(...)", |
Current coverage is 84.75% (diff: 77.77%)@@ master #15099 diff @@
==========================================
Files 145 145
Lines 51220 51220
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43415 43414 -1
- Misses 7805 7806 +1
Partials 0 0
|
Contributor
Author
|
updated |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Oct 27, 2018
jreback
pushed a commit
that referenced
this pull request
Oct 28, 2018
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Oct 28, 2018
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202. Follow-up to pandas-devgh-23375.
jreback
pushed a commit
that referenced
this pull request
Oct 28, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202. Follow-up to pandas-devgh-23375.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202. Follow-up to pandas-devgh-23375.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202. Follow-up to pandas-devgh-23375.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14279