generate_adhoc_ssl_pair: make issuer match subject#1430
generate_adhoc_ssl_pair: make issuer match subject#1430davidism merged 1 commit intopallets:masterfrom mephi42:master
Conversation
With this change, the generated certificate can be trusted,
and the following command starts working:
openssl s_client -showcerts -connect dev:443 -verifyCAfile dev.crt </dev/null
|
Why does it need to be trusted? The command is not meant for making a good certificate, it's meant for quickly making a development one. Clearly marking it as such, as is done now, seems better. |
|
I found the ability to trust dev certificate useful for testing client's ability to work with custom CA bundles. In particular, when implementing |
|
I'm not an expert on SSL. Why is the current version not trustable? What does the change do to make it so? |
|
The way I see it is that when a web server presents a certificate to a client, a client uses the issuer field to build the trust chain. Currently issuer points to the non-existent When I change the issuer field to point to the dev certificate itself, and trust the dev certificate using e.g. |
With this change, the generated certificate can be trusted,
and the following command starts working: