Never send Content-Length for 204#1294
Merged
lepture merged 1 commit intopallets:masterfrom May 13, 2018
ikonst:fix-204
Merged
Conversation
Contributor
|
What version did this fix get released to? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With flask-restful, it's easy to make a malformed response by doing
return '', 204orreturn None, 204. It might be idiomatic, but it would result in a 204 response with a non-empty body (containing a JSON payload such as''ornull).We used to reset the Content-Length to 0 for status code 204, but since 1c70c3e we keep
Content-Length: Nwhile the body is eliminated (seeBaseResponse.get_app_iter). This broke existing flask-restful applications:flask-restful/flask-restful#736
Per section 3.3.2 of RFC 7230, "a server MUST NOT send a Content-Length header field in any response with a status code of 1xx (Informational) or 204 (No Content)". This change enforces it in
get_wsgi_headers.