Adding a default parameter to builtin map filter#985
Merged
davidism merged 2 commits intopallets:masterfrom Jul 22, 2019
Merged
Adding a default parameter to builtin map filter#985davidism merged 2 commits intopallets:masterfrom
davidism merged 2 commits intopallets:masterfrom
Conversation
Member
|
Hey, really sorry about this, but I merged #1018 before I realized this PR was earlier. They ended up looking pretty much identical, but there's a few things in this one that I think make the other a bit cleaner, so I'm going to rebase and merge this one too. |
d747d74 to
3920ece
Compare
3920ece to
f9e12e4
Compare
f9e12e4 to
8178361
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on issue #557 to add a
defaultparameter for themapfilter.This required adding a parameter to
make_attrgetter, which is also used by many other functions. Adefaultparameter could also be used in other filters as well, likejoinorsum.Tests also written and passed.
Written at sprints at Pycon2019