add default to map filter#1018
Merged
davidism merged 1 commit intopallets:masterfrom Jul 22, 2019
Merged
Conversation
davidism
requested changes
Jun 11, 2019
Member
davidism
left a comment
There was a problem hiding this comment.
See comments, and needs tests as well.
kbiggers
commented
Jun 19, 2019
Contributor
Author
kbiggers
left a comment
There was a problem hiding this comment.
See changes in my most recent commit. Changes should be addressed.
davidism
reviewed
Jun 26, 2019
Member
|
Sorry, noticed a couple more review items, looks good overall. |
davidism
approved these changes
Jul 22, 2019
Member
|
OK, I merged this then noticed #985, which came a month before this and looks incredibly similar. Did I miss something where this was a continuation of that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added ability to pass default entry to map filter if attribute is not defined. If default is not defined it defaults to an empty string.
fixes #557