Skip to content

add ImportLibResourceLoader#976

Closed
gsemet wants to merge 3 commits intopallets:masterfrom
gsemet:master
Closed

add ImportLibResourceLoader#976
gsemet wants to merge 3 commits intopallets:masterfrom
gsemet:master

Conversation

@gsemet
Copy link
Copy Markdown

@gsemet gsemet commented May 2, 2019

closes #970

@gsemet gsemet changed the title WIP: add ImportLibResourceLoader add ImportLibResourceLoader May 2, 2019
@tobywf
Copy link
Copy Markdown

tobywf commented Jun 22, 2019

Seems like by adding tests/res/templates/__init__.py, *.pyc files are being generated, which trips up the FileSystemLoader when trying to parse those as utf-8. I have a fix, but I'm unsure how to update somebody else's pull request. @gsemet, please let me know how you would like to handle this. Happy to cherry-pick your commit onto a fork and create new PR (retaining the original author, or resetting the commit's author if you prefer), or somehow update your fork and therefore this PR. Thanks!

@gsemet
Copy link
Copy Markdown
Author

gsemet commented Jun 22, 2019

Oh if you know how to fix it, you can put a PR on top of my PR :)

@tobywf
Copy link
Copy Markdown

tobywf commented Jun 23, 2019

Please see #1023 and gsemet#1 . Hope this helps!

@ghost
Copy link
Copy Markdown

ghost commented Sep 16, 2019

is this going to be fixed and merged soon?

@gsemet
Copy link
Copy Markdown
Author

gsemet commented Sep 16, 2019

ok i have merged your pr but i will maybe redo it

@ghost
Copy link
Copy Markdown

ghost commented Sep 16, 2019

@gsemet when can i expect it to be merged into jinja?

@gsemet
Copy link
Copy Markdown
Author

gsemet commented Sep 16, 2019

I’m looking to rebase it properly

@gsemet gsemet force-pushed the master branch 2 times, most recently from f0b34a8 to 5ff4707 Compare September 16, 2019 11:15
@gsemet
Copy link
Copy Markdown
Author

gsemet commented Sep 16, 2019

ok, should be ok now :)

Signed-off-by: Gaetan Semet <gaetan.semet@renault.com>
@ghost
Copy link
Copy Markdown

ghost commented Sep 16, 2019

will wait for this to be merged

@davidism
Copy link
Copy Markdown
Member

I really appreciate that you started work on this, getting rid of the dependency on setuptools and pkg_resources is good. I'm closing this in favor of #1082, which only updates the existing PackageLoader and avoids the constraints of importlib.resources.

@davidism davidism closed this Oct 16, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace pkg_resource by importlib_resources

3 participants