Merge in pallets/jinja:master and fix unit tests#1
Merged
gsemet merged 22 commits intogsemet:masterfrom Sep 16, 2019
tobywf:master
Merged
Merge in pallets/jinja:master and fix unit tests#1gsemet merged 22 commits intogsemet:masterfrom tobywf:master
gsemet merged 22 commits intogsemet:masterfrom
tobywf:master
Conversation
These have been broken for about a month now because of the upgrade to Sphinx 2. This upgrade happened automatically because we do not have the version pinned. Luckily this issue appears to only be from having Python 2 syntax in the docs script, so making that compatible with Python 3 fixes the error and allows the docs to pass.
Fix tox docs-html builds
The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython. CPython 3.8 has added a SyntaxWarning for this.
Ticket is referenced in [#Issue 1](https://github.com/pallets/meta/issues/1) in the Meta repo. I spoke with @davidism and the decision was to use Contributor Covenant. It has easy GitHub integration and quality content.
Create CODE_OF_CONDUCT.md
* Add ChainableUndefined allowing getattr & getitem
Allows using default values with chains of items or attributes that may
contain undefined values without raising a jinja2.exceptions.UndefinedError.
>>> import jinja2
>>> env = jinja2.Environment(undefined=jinja2.ChainableUndefined)
>>> env.from_string("{{ foo.bar['baz'] | default('val') }}").render()
'val'
* Remove class decorator from ChainableUndefined
Remove duplicated testcase
docs(filters): fix typo `columwrapper` => `columnwrapper`
Added new method itervalues() to LRUCache and deprecated itervalue()
Follow suggestion to use :noindex: for the instance in api."
Document nested extends and super.super().
Fix typo "the the"
This was referenced Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue pallets#970 , please see existing pull request pallets#976 . The merge from
pallets/jinja:masterlooks weird, and to show the CI passes, I've also cut pallets#1023 to show how it would look like. Feel free to close either PR depending on which path you choose.