Fixing compiler handling of parens around boolean comparisons.#938
Merged
davidism merged 1 commit intopallets:masterfrom Oct 7, 2019
Merged
Fixing compiler handling of parens around boolean comparisons.#938davidism merged 1 commit intopallets:masterfrom
davidism merged 1 commit intopallets:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to: [BUG] Unexpected TypeError when using boolean test inside numeric expression
Full details in the latest post in that issue.
Not sure if this is the right place for a unit test, or if this is the right test; I didn't see any compiler-specific tests, and I wasn't able to get them running successfully on my laptop. However, I applied the change directly to the installed version of jinja2 and it fixed the problem, and the code in the unit test in the commit executes as desired when run on its own.