Skip to content

ignore errno.ENOTDIR in open_if_exists#822

Closed
praiskup wants to merge 1 commit intopallets:2.10.xfrom
praiskup:enotdir
Closed

ignore errno.ENOTDIR in open_if_exists#822
praiskup wants to merge 1 commit intopallets:2.10.xfrom
praiskup:enotdir

Conversation

@praiskup
Copy link
Copy Markdown

@praiskup praiskup commented Mar 14, 2018

Fixes #821

@praiskup praiskup changed the base branch from master to 2.10-maintenance March 14, 2018 08:50
@ThiefMaster
Copy link
Copy Markdown
Member

ThiefMaster commented Mar 14, 2018

Check if there's a testcase for the other error cases; if there is one add one for this one as well, otherwise I think it's not needed (unless you want to cover it of course)

@ishakir ishakir mentioned this pull request Apr 11, 2018
Closed
@ishakir
Copy link
Copy Markdown

ishakir commented Apr 11, 2018

Given that #839 has been closed, is there anything blocking this one being merged?

@praiskup
Copy link
Copy Markdown
Author

praiskup commented May 7, 2018

@ThiefMaster sorry for late reply, no there haven't been tests for open_if_exists yet. It would be nice if we could merge this as-is; otherwise let me know if something needs to be changed.

@praiskup
Copy link
Copy Markdown
Author

praiskup commented Jun 15, 2018

Ping, can I help to move this forward?

@davidism
Copy link
Copy Markdown
Member

davidism commented Jun 18, 2018

Would you add a changelog entry for this?

praiskup added a commit to praiskup/jinja that referenced this pull request Jun 18, 2018
@praiskup
ignore errno.ENOTDIR in open_if_exists
5ef860f 
Fixes pallets#821, pallets#822
@praiskup
Copy link
Copy Markdown
Author

praiskup commented Jun 18, 2018

Done, please take a look.

@praiskup
Copy link
Copy Markdown
Author

praiskup commented Jun 18, 2018

The CI failure isn't related to this PR, am I right?

@ishakir
Copy link
Copy Markdown

ishakir commented Jun 20, 2018

CI failure definitely not related to this change. Only failing on Python 3.3 with some venv error

@pallets pallets deleted a comment from ishakir Aug 7, 2018
@pallets pallets deleted a comment from tsopokis Nov 7, 2018
@davidism davidism closed this Mar 19, 2019
@praiskup
Copy link
Copy Markdown
Author

praiskup commented Mar 19, 2019

@davidism may I do something for this PR?

@davidism davidism reopened this Mar 19, 2019
@praiskup
Copy link
Copy Markdown
Author

praiskup commented Mar 19, 2019 via email

praiskup added a commit to praiskup/jinja that referenced this pull request Mar 20, 2019
@praiskup
ignore errno.ENOTDIR in open_if_exists
454f438 
Fixes pallets#821, pallets#822
praiskup added a commit to praiskup/jinja that referenced this pull request Mar 20, 2019
@praiskup
ignore errno.ENOTDIR in open_if_exists
2eecd25 
Fixes pallets#821, pallets#822
@praiskup praiskup mentioned this pull request Mar 20, 2019
Closed
@davidism davidism changed the base branch from 2.10-maintenance to 2.10.x April 6, 2019 20:43
@kevin-brown
Copy link
Copy Markdown
Member

kevin-brown commented May 6, 2019

This is going to need to be rebased against the latest 2.10.x branch. Right now there is a build running against Python 3.3 which is failing, and in the latest copy of that branch we no longer test against Python 3.3 (because it is EOL).

@praiskup
Copy link
Copy Markdown
Author

praiskup commented May 6, 2019 •
edited
Loading

I thought we can close this, and keep only #963? edit: rebased anyways

@davidism davidism mentioned this pull request Oct 13, 2019
Merged
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@praiskup @ThiefMaster @ishakir @davidism @kevin-brown