Finalize should only apply to variable #63#535
Closed
godsarmy wants to merge 1 commit intopallets:masterfrom
godsarmy:fix_finalize_variable
Closed
Finalize should only apply to variable #63#535godsarmy wants to merge 1 commit intopallets:masterfrom godsarmy:fix_finalize_variable
godsarmy wants to merge 1 commit intopallets:masterfrom
godsarmy:fix_finalize_variable
Conversation
|
As a side remark, if |
|
What the status of this PR? Is the problem with LaTeX autoescape still cannot be solved https://stackoverflow.com/q/8001986/7444782 ? |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I submit this PR to resolve the issue of #63 as i believe it is incorrect to apply finalize to any value in the template (constant, condition).
I think the root cause is self-explaining in the unit test "<{{ none }} >" as the original implementation tried to change none to empty string. However, none is not a variable in context but a constant, so instead, it should not be applied with finalize function.