preserve quotes between nodes in native env#1086
Merged
Conversation
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Oct 23, 2019
Fixes ansible#58527 Updates our copy of native_concat to include changes introduced in pallets/jinja#1086.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1020
Due to the way the lexer works,
'{{ a }}', '{{ b }}'would get parsed as the nodes',{{ a }},', ',{{ b }},'.native_concatwould get called on the intermediate node', ', which parses to a string, which drops the quotes.Now, if
literal_evalresults in a string, it is re-quoted except for the top-level concat inTemplate.render. The original quote character is preserved. This carries the quotes through to the final call toliteral_eval, so quotes around expressions are preserved.cc @jctanner @mkrizek