Werkzeug should not block propagated exceptions from Flask #1679
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_basic.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
07f14bf to
952a6c8
Compare
davidism
added a commit
that referenced
this pull request
Jan 26, 2016
Werkzeug should not block propagated exceptions from Flask
Member
|
I don't know why I never noticed that PyCharm wasn't breaking on exceptions, but it works as expected and as described in the docs now. Thanks for fixing this. |
davidism
added a commit
that referenced
this pull request
Jun 23, 2016
This got dropped during the cli simplification. Re: #1679
davidism
added a commit
that referenced
this pull request
Jun 23, 2016
This got dropped during the cli simplification. Re: #1679
untitaker
added a commit
to untitaker/flask
that referenced
this pull request
Sep 6, 2016
untitaker
added a commit
to untitaker/flask
that referenced
this pull request
Sep 6, 2016
untitaker
added a commit
that referenced
this pull request
Sep 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1674.
By having Werkzeug always configured to let exceptions through we achieve the correct behavior for Flask. If Flask is configured to propagate exceptions (implicitly or explicitly, doesn't matter), then Werkzeug will get these exceptions and pass them through as well. If Flask is configured to not propagate exceptions, then Werkzeug will never see them, so no harm done if it is configured to pass them.
It looks like there is no testing for the new cli, so I have only added a test for the
app.run()way of starting a server.