Fix errorhandler HTTPException normalization #1383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When declaring an errorhandler for a numeric code after setting one for the associated exception, the second one doesn't take precedence.
This is barely noticeable since @3d67736, but the previous code to normalize the error condition missed its apparent purpose: code_or_exception will never be an instance of HTTPException, as one might only supply an exception class and not an object. The bug still appeared when you declare an errorhandler for a numeric code after setting one for the respective exception: Then, the exception's handler always took precedence. The HTTPException base class has no code and therefore must be dealt with like any other exception.
Member
|
The test case passes without changes in master. |
cerickson
added a commit
to cerickson/flask
that referenced
this pull request
May 22, 2017
Error handlers are now returned in order of blueprint:code, app:code, blueprint:HTTPException, app:HTTPException, None Corresponding tests also added. Ref issue pallets#941, pr pallets#1383, pallets#2082, pallets#2144
cerickson
added a commit
to cerickson/flask
that referenced
this pull request
May 23, 2017
Error handlers are now returned in order of blueprint:code, app:code, blueprint:HTTPException, app:HTTPException, None Corresponding tests also added. Ref issue pallets#941, pr pallets#1383, pallets#2082, pallets#2144
cerickson
added a commit
to cerickson/flask
that referenced
this pull request
May 23, 2017
Error handlers are now returned in order of blueprint:code, app:code, blueprint:HTTPException, app:HTTPException, None Corresponding tests also added. Ref issue pallets#941, pr pallets#1383, pallets#2082, pallets#2144
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is barely noticeable in the development code since #839, but in the latest released version. The current code to normalize the error condition misses its apparent purpose: code_or_exception will never be an instance of HTTPException, as one might only supply an exception class and not an object.
The bug still appears when you declare an errorhandler for a numeric code after setting one for the respective exception: Then, the exception's handler will always take precedence.
The HTTPException base class has no code and therefore must be dealt with like any other exception.