Fix package_name resolution when module differs from distribution name#3582
Open
kdeldycke wants to merge 1 commit into
Open
Fix package_name resolution when module differs from distribution name#3582kdeldycke wants to merge 1 commit into
package_name resolution when module differs from distribution name#3582kdeldycke wants to merge 1 commit into
Conversation
002b282 to
ce308a9
Compare
This was
linked to
issues
Jun 11, 2026
This was referenced Jun 11, 2026
kdeldycke
added a commit
to kdeldycke/click-extra
that referenced
this pull request
Jun 11, 2026
…istribution name Refs: pallets/click#3582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue we glossed over when closing #2331: I analyzed the bug report as requiring a new slot/field to be added to the
@version_optiondecorator. I promptly close the issue as we decided in #3527 to freeze@version_option.But looking closely #2331 did not asked for a new
module_namefield. That was my suggestion on how to address the user request.So reframing it, #2331 is a report that
@version_optionis producing aRuntimeErrorfor users in some legitimate situations. This breaks the out-of-the-box experience of@version_option.In fact, the limitation has been pointed out by @davidism a couple of years ago at #1884 (comment):
So this is a PR to implement that fix.
Addresses:
version_optiondoesn't automatically detect version anymore with click 8.0.0 #1884version_optionmodule name and package name are not equivalent #2331version_optionignorespackage_name#3125