fix: Skip flaky pager test on macOS with free-threaded Python 3.14t#3470
Merged
Conversation
351484d to
aa9442c
Compare
Add a MAC platform constant in `_compat.py` and use it to skip `test_echo_via_pager` on macOS when running free-threaded Python, where generator exception tests are flaky in parallel execution.
aa9442c to
d15f3c2
Compare
Contributor
Author
|
@davidism @Rowlando13 |
Member
|
Oops, got this backwards, should be |
Member
Contributor
Author
|
@davidism My bad! Should have caught it earlier. 😅 |
This was referenced May 22, 2026
kdeldycke
added a commit
to kdeldycke/click
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily fixes flaky test failure for
test_echo_via_pageron macOS with 3.14t (free-threading) by skipping them for macOS + Python 3.14t combination until we figure out how to make the test result consistently pass whentest_echo_via_pagerandtest_stream_lifecycleare running in parallel.fixes #2899