Skip to content

Do not format precompiled Groovy convention plugins#1583

Merged
bulldozer-bot[bot] merged 2 commits intodevelopfrom
callumr/handle-precompiled-groovy-dsl-plugins
Feb 18, 2026
Merged

Do not format precompiled Groovy convention plugins#1583
bulldozer-bot[bot] merged 2 commits intodevelopfrom
callumr/handle-precompiled-groovy-dsl-plugins

Conversation

@CRogers
Copy link
Contributor

@CRogers CRogers commented Feb 18, 2026 •
edited
Loading

Before this PR

In #1568, we tweaked the excludes for generated code to not blanket exclude build files. However, an internal repo uses Convention Plugins which make these Java classes we do not need to format.

Since these live at build/groovy-dsl-plugins/output, they do not currently get excluded and we get errors of the forms:

Execution failed for task ':spotlessJavaCheck'.
> The following files had format violations:
      build/groovy-dsl-plugins/output/adapter-src/NamwConventionsPlugin.java
          @@ -1,21 +1,29 @@
          -//CHECKSTYLE:OFF
          -import·org.gradle.util.GradleVersion;
          +/*
          +·*·(c)·Copyright·2026·Palantir·Technologies·Inc.·All·rights·reserved.
          +·*/
          +//·CHECKSTYLE:OFF
           import·org.gradle.groovy.scripts.BasicScript;
           import·org.gradle.groovy.scripts.ScriptSource;
           import·org.gradle.groovy.scripts.TextResourceScriptSource;
           import·org.gradle.internal.resource.StringTextResource;
          +import·org.gradle.util.GradleVersion;
          +
           /**
           ·*·Precompiled·name·script·plugin.
           ·**/
           @SuppressWarnings("DefaultPackage")
          -public·class·NameConventionsPlugin·implements·org.gradle.api.Plugin<org.gradle.api.internal.project.ProjectInternal>·{
          +public·class·NameConventionsPlugin

After this PR

==COMMIT_MSG==
Exclude precompiled Convention Plugins from formatting
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from crogoz February 18, 2026 17:24
@changelog-app
Copy link

changelog-app bot commented Feb 18, 2026 •
edited by CRogers
Loading

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Exclude precompiled Convention Plugins from formatting

Check the box to generate changelog(s)

  • Generate changelog entry

@changelog-app
Copy link

changelog-app bot commented Feb 18, 2026

✅ Successfully generated changelog entry!

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

📋Changelog Preview

🐛 Fixes

gluxon
gluxon previously approved these changes Feb 18, 2026
View reviewed changes
Copy link

@gluxon gluxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

felixdesouza
felixdesouza previously approved these changes Feb 18, 2026
View reviewed changes
@CRogers
Merge branch 'develop' of github.com:palantir/palantir-java-format in…
99427bf 
…to callumr/handle-precompiled-groovy-dsl-plugins
@policy-bot policy-bot bot dismissed stale reviews from gluxon and felixdesouza February 18, 2026 17:54

Invalidated by push of 99427bf

@felixdesouza
Copy link

felixdesouza commented Feb 18, 2026

👍

@bulldozer-bot bulldozer-bot bot merged commit 80b0a2d into develop Feb 18, 2026
7 checks passed
@bulldozer-bot bulldozer-bot bot deleted the callumr/handle-precompiled-groovy-dsl-plugins branch February 18, 2026 18:06
@autorelease3
Copy link

autorelease3 bot commented Feb 18, 2026

Released 2.88.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gluxon gluxon gluxon left review comments

@felixdesouza felixdesouza felixdesouza left review comments

@crogoz crogoz Awaiting requested review from crogoz

Assignees

No one assigned

Labels

autorelease merge when ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CRogers @felixdesouza @gluxon