fix: parse PURL for name/namespace#583
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
PURL-SPECIFICATION.rst
Outdated
| - This is the ``version`` | ||
|
|
||
| - Split the ``remainder`` once from right on '/' | ||
| - Strip all leading and trailing '/' characters (e.g., '/', '//', '///' and |
There was a problem hiding this comment.
this was the most relevant - the missing - part
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
@jkowalleck @ppkarwasz We have just in the last hour merged #589 to split PURL-SPECIFICATION.rst into markdown files in the new /docs directory. This was needed to prepare for publishing the Ecma Standard document and later for documentation on the packageurl.org website. |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
done. also reverted changes on will do so again, if needed, after
sure thing. will update this PR again, to prevent any merge conflicts - if needed :) |
|
@jkowalleck Thank you |
mjherzog
left a comment
There was a problem hiding this comment.
Agree to merge and update tests following
- Improved 'name' and 'namespace' parsing (package-url/purl-spec#582 - package-url/purl-spec#583) - Improved t/99-*.t tests
name/namespaceis faulty, according to spec #582using the previously broken example from the issue #582
parsing
pkg://////foo-type/////bar-namespace////bazz-name/////@version#pkg://////foo-type/////bar-namespace////bazz-name/////@version?pkg://////foo-type/////bar-namespace////bazz-name/////@version:pkg//////foo-type/////bar-namespace////bazz-name/////@versionfoo-type/////bar-namespace////bazz-name/////@version/////bar-namespace////bazz-name/////@version@version////bar-namespace////bazz-name/////////bar-namespace////bazz-name/////bar-namespace///bazz-name/and discard empty segments ...bar-namespace