Skip to content

Build kernel modules in CI.#98

Merged
fruffy merged 3 commits into
mainfrom
fruffy/enable_kernel_modules
Jun 22, 2025
Merged

Build kernel modules in CI.#98
fruffy merged 3 commits into
mainfrom
fruffy/enable_kernel_modules

Conversation

@fruffy

@fruffy fruffy commented May 24, 2025

Copy link
Copy Markdown
Contributor

Let's see what breaks.

Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy force-pushed the fruffy/enable_kernel_modules branch from 88cf6ab to a7fbb6b Compare June 21, 2025 17:54
@vgurevich

vgurevich commented Jun 21, 2025

Copy link
Copy Markdown
Contributor

@fruffy -- attached is the diff that allows the kernel modules from SDE-9.13.4 to compile on Ubuntu-22.04 with Linux kernel 6.8.0 and Gcc-12.

I think it should work on open-p4studio as well. Unfortunately, I cannot verify its correctness beyond being able to compile and load bf-knet module, since I do not have access to the hardware. But basically these are all trivial changes that make the newer gcc happy, that's all.

ubuntu-22.04-linux-6.8.0-sde_kmod.patch

fruffy added 2 commits June 21, 2025 16:13
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
@vgurevich

Copy link
Copy Markdown
Contributor

Good catch, @fruffy -- I replaced a number of strlcpy()s. Not sure why others were not flagged (for me at least).

@fruffy fruffy requested a review from vgurevich June 21, 2025 23:36

@vgurevich vgurevich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but it would be really nice if someone with the access to the HW can actually test these.

@fruffy fruffy merged commit 4fc6e40 into main Jun 22, 2025
2 checks passed
@fruffy fruffy deleted the fruffy/enable_kernel_modules branch June 22, 2025 16:56
n1tr0-5urf3r pushed a commit to n1tr0-5urf3r/open-p4studio that referenced this pull request Jun 25, 2025
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: Fabian Ihle <fabian.ihle@uni-tuebingen.de>
@n1tr0-5urf3r

Copy link
Copy Markdown
Contributor

I approve, but it would be really nice if someone with the access to the HW can actually test these.

Hi there! I can confirm that the changed files work on the actual HW (tested on a Tofino 2). I applied the same procedure I described in #101 to test it. Feel free to ping me if you need some tests on the HW done in the future! :)

n1tr0-5urf3r pushed a commit to n1tr0-5urf3r/open-p4studio that referenced this pull request Jun 26, 2025
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: Fabian Ihle <fabian.ihle@uni-tuebingen.de>
n1tr0-5urf3r pushed a commit to n1tr0-5urf3r/open-p4studio that referenced this pull request Jun 27, 2025
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: Fabian Ihle <fabian.ihle@uni-tuebingen.de>
rcgoodfellow pushed a commit to oxidecomputer/tofino-sde that referenced this pull request Feb 21, 2026
Signed-off-by: fruffy <fruffy@nyu.edu>
jafingerhut pushed a commit to jafingerhut/open-p4studio that referenced this pull request Feb 26, 2026
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants