hw/rdc_setup.sh: add bf_switchd.c#116
Merged
Merged
Conversation
jafingerhut
approved these changes
Sep 21, 2025
jafingerhut
left a comment
Contributor
There was a problem hiding this comment.
I have no way to test this personally, and I expect most other likely reviewers will not, either, but trust Alexander on this.
Contributor
|
@alexandergall DCO check is failing. Click on "DCO" link under "Some checks were not successful" on this page #116 for instructions on how to modify this PR to pass it, or create a new PR and use 'git commit -s' when committing. |
The code for locating the Credo/Avago firmware is disabled in bf_switchd.c, which leads to a non-working system when the procedure to merge with the RDC is applied. Currently, this is the only difference between the open-p4studio and RDC versions of the file, hence it is safe to simply add bf_switchd.c to the list of files to copy. Signed-off-by: Alexander Gall <alexander.gall@gmail.com>
b922502 to
cfbbe42
Compare
Contributor
|
@fruffy @vgurevich Any concerns with merging this? |
fruffy
reviewed
Oct 20, 2025
Signed-off-by: Alexander Gall <alexander.gall@gmail.com>
fruffy
approved these changes
Oct 26, 2025
rcgoodfellow
pushed a commit
to oxidecomputer/tofino-sde
that referenced
this pull request
Feb 21, 2026
Signed-off-by: Alexander Gall <alexander.gall@gmail.com>
jafingerhut
pushed a commit
to jafingerhut/open-p4studio
that referenced
this pull request
Feb 26, 2026
Signed-off-by: Alexander Gall <alexander.gall@gmail.com> Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for locating the Credo/Avago firmware is disabled in bf_switchd.c, which leads to a non-working system when the procedure to merge with the RDC is applied. Currently, this is the only difference between the open-p4studio and RDC versions of the file, hence it is safe to simply add bf_switchd.c to the list of files to copy.