Dropshot-based websocket endpoint & Add Progenitor-based client#206
Merged
Conversation
pfmooney
reviewed
Sep 1, 2022
Comment on lines
+12
to
+13
| pub mod generated; | ||
| pub mod handmade; |
Contributor
There was a problem hiding this comment.
From a docs standpoint, do we want the modules themselves to be visible, or simply exposed via the pub use below?
Contributor
Author
There was a problem hiding this comment.
Added some more clarifying documentation around it and only made handmade pub when it's not globally pub use'd
3fc635c to
aed73b1
Compare
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Sep 30, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Sep 30, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
luqmana
approved these changes
Oct 5, 2022
luqmana
left a comment
Contributor
There was a problem hiding this comment.
Thanks lif! The generated vs handmade stuff is annoying but the sooner we get this landed the sooner we can migrate the old users.
This moves the websocket-related boilerplate into the code generated by Dropshot's `#[channel]` annotation macro. (rel: oxidecomputer/dropshot#403 )
- Validate/generate an OpenAPI schema in a test, as done in omicron - Provide an (optional, for now) codegen'd client from the OpenAPI
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 8, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 8, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 8, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 8, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 8, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 18, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 18, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 20, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 20, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 20, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 20, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 22, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 25, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 26, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
pushed a commit
to lifning/omicron
that referenced
this pull request
Oct 26, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206)
lifning
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 27, 2022
- Includes updates to progenitor and reqwest 0.11.12 for client support for Dropshot websocket channels. - Literally only passes through the websocket, does not yet include the serial output buffering done by its parent GET endpoint. - Adds support for ensuring a websocket endpoint gets upgraded in nexus integration tests (i.e. test_unauthorized). - Begins migrating sled-agent's propolis-client usage to the new progenitor-generated version (oxidecomputer/propolis#206) Co-authored-by: lif <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Dropshot 'channel' for serial console endpoint
This moves the websocket-related boilerplate into the code generated by Dropshot's
#[channel]annotation macro.(rel: oxidecomputer/dropshot#403 )
Generate an API client with Progenitor
This validates and/or generates an OpenAPI schema in a test, as done in omicron (with expectorate).
The generated client is currently opt-in via a feature flag, so as to mitigate breakages while migrating our other codebases from the handwritten client code.
(rel: oxidecomputer/progenitor#183 )