[reconfigurator-planning] clear remove-mupdate-override from blueprint even if no target release is set#9082
Merged
Conversation
Created using spr 1.3.6-beta.1
sunshowers
commented
Sep 24, 2025
Comment on lines
196
to
198
| DNS zone: "control-plane.oxide.internal" (unchanged) | ||
| unchanged names: 51 (records: 65) | ||
| unchanged names: 52 (records: 68) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is being fixed separately, I believe -- it's here to make tests pass.
Contributor
There was a problem hiding this comment.
Yeah, I think this is broken on main. But probably fine to just land this PR to fix it?
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Sep 24, 2025
Comment on lines
196
to
198
| DNS zone: "control-plane.oxide.internal" (unchanged) | ||
| unchanged names: 51 (records: 65) | ||
| unchanged names: 52 (records: 68) | ||
|
|
Contributor
There was a problem hiding this comment.
Yeah, I think this is broken on main. But probably fine to just land this PR to fix it?
leftwo
pushed a commit
that referenced
this pull request
Sep 26, 2025
…t even if no target release is set (#9082) Currently: * if a target release is set, we go ahead and clear the remove-mupdate-override instruction from blueprints, regardless of whether artifacts match * if no target release is set, we don't do that This behavior is inconsistent. We shouldn't gate the mupdate override part of the state machine on a target release not being set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently:
This behavior is inconsistent. We shouldn't gate the mupdate override part of the state machine on a target release not being set.