[sled-agent] Launch from bootstrap agent, derive bootstrap addresses, allocate sled /64s#904
Merged
Conversation
jmpesp
approved these changes
Apr 14, 2022
jmpesp
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, some questions:
Comment on lines
+464
to
+467
| // NOTE: This is a "point-of-no-return" -- before sending any requests | ||
| // to neighboring sleds, ensure that we've recorded our plan to durable | ||
| // storage. This way, if the RSS power-cycles, it can idempotently | ||
| // execute the same allocation plan. |
Contributor
There was a problem hiding this comment.
the way this is worded seems like it's not done yet. did create_plan perform a flush to durable storage?
Collaborator
Author
There was a problem hiding this comment.
I'll move the comment up, indicating that it is supposed to refer to the moment create_plan completes.
create_planperforms the write to durable storage.- It's not calling flush explicitly, but I believe it's being implicitly called when the
tokio::fs::write- which callsstd::fs::write- which itself callsFile::create-drops the createdFileobject.
Comment on lines
+14
to
+16
| // This modifies global state of the target machine, creating | ||
| // an address named "bootstrap6", akin to what the bootstrap | ||
| // agent should do. |
Contributor
There was a problem hiding this comment.
is this cleaned up after the test?
bnaecker
reviewed
Apr 18, 2022
bnaecker
left a comment
Collaborator
There was a problem hiding this comment.
This looks really good. I have a few clarifying comments and questions, but overall a +1 from me!
Collaborator
|
Looks like you've got a test flake on the Otherwise, LGTM! |
bnaecker
approved these changes
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap Agent
/64for which it should be responsible. Store configuration data to local storage withinOMICRON_CONFIG_PATHto automatically launch these agents on reboot, after RSS setup.PeerMonitorObserverstructure that may be used to await the notification of new peers within the bootstrap agent.Sled Agent
RSS
Configs (mostly in
smf/)TODO
PeerMonitorObserverstructure, maybe it can be simplifiedTODOs for later PRs (but which should be unblocked now)
Fixes #821