Slightly change IPv6 prefix used and update README with address mappings.#830
Merged
Conversation
0e37116 to
256ced2
Compare
smklein
approved these changes
Mar 30, 2022
Contributor
|
🚢 |
Co-authored-by: Sean Klein <sean@oxide.computer>
leftwo
pushed a commit
that referenced
this pull request
Jul 15, 2023
Crucible: Add quota to agent created datasets (#835) Switch to building on heliosv2 (#830) Minor clippy cleanup (#832) Update to latest dropshot (#829) Propolis: The above crucible changes Switch to building on heliosv2 (#461) clean up cargo check/clippy errors when built with Rust 1.71 (#462) Add some VMM_DESTROY_VM polish to bhyve-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I've just been doing it wrong but I was getting annoyed with the in-repo config not matching my test env (we had some hardcoded 192.168.1.x addresses for Nexus & Sled Agent). Key insight I had was hey, we already have all this machinery for using these IPv6 local addresses, why not just use that by default.
The goal here being that one should be able to get omicron up and running without having to manually create interfaces, assign addresses or even modify the existing configs.
Also updated the README tonote what addresses correspond to what. I understand a lot of this is in flux as it gets closer to the "real" setup, but in the meanwhile why not make the on-ramp a bit easier.
Note: the
fd00:1234tofd00:1deis purely for the vanity 😛