Skip to content

(1/5) [nexus] Add Affinity/Anti-Affinity Groups to API (unimplemented)#7443

Merged
smklein merged 9 commits into
mainfrom
affinity-api
Feb 19, 2025
Merged

(1/5) [nexus] Add Affinity/Anti-Affinity Groups to API (unimplemented)#7443
smklein merged 9 commits into
mainfrom
affinity-api

Conversation

@smklein

@smklein smklein commented Jan 30, 2025

Copy link
Copy Markdown
Collaborator

Pulled out of #7076

Exposes Affinity/Anti-Affinity Groups in the API, but as unimplemented.

@hawkw hawkw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good to me --- more or less precisely what I would expect based on what's specified in RFD 522. Nothing controversial here.

Comment thread common/src/api/external/mod.rs
Comment thread nexus/external-api/src/lib.rs Outdated
Comment thread common/src/api/external/mod.rs

@david-crespo david-crespo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good.

Comment thread common/src/api/external/mod.rs Outdated
Comment thread nexus/external-api/src/lib.rs
@smklein smklein merged commit 18e317b into main Feb 19, 2025
@smklein smklein deleted the affinity-api branch February 19, 2025 18:21
hawkw pushed a commit that referenced this pull request Feb 21, 2025
#7443)

Pulled out of #7076

Exposes Affinity/Anti-Affinity Groups in the API, but as unimplemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants