Properly check prior instance/vmm states when starting an instance#6278
Merged
Conversation
Fix the following instance start dispositions: - an instance with no active VMM can only be started if it's in the "NoVmm" instance state - an instance with a migrating active VMM has been started, so allow start to succeed for idempotency - an instance with a SagaUnwound active VMM is allowed to be started again (the new start saga's VMM supplants the old VMM) Add some unit tests to cover these cases.
hawkw
approved these changes
Aug 9, 2024
hawkw
added a commit
that referenced
this pull request
Aug 9, 2024
This makes @gjcolombo's change from #6278 a bit more consistent with the rest of the code, and in particular, ensures that we always present the user with the same instance state names. It also addresses the `SagaUnwound` behavior Greg pointed out in [this comment][1]. [1]: #5749 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following instance start dispositions:
Add some unit tests to cover these cases.
Fixes #6274.