update to Rust 1.78.0 / bump OPTE to 0.29.250#5722
Conversation
This appears to go away when I change the rust-toolchain.toml back. |
|
OPTE fix at oxidecomputer/opte#527 |
jgallagher
left a comment
There was a problem hiding this comment.
Thanks - all the code changes LGTM. I'm a little nervous about the helios/deploy failure, but I don't see any smoking guns there - just NTP failing to sync, which I think is a known flake (#5598).
|
It has now happened twice in a row, which is kind of concerning (I hit retry once already). |
|
I had a quick peek at the logs there: I don't think this is a flake. Part of an OPTE API bump now is that you need to update maghemite and its binaries to a compatible version, as |
|
Aha. I will hold off on this until that can get merged then. |
The most severe changes in this PR are dead code removal; I am not exactly sure why, but it seems like dead code detection became a little more robust between 1.77 and 1.78.
The 1.78.0 toolchain includes two new Clippy lints that are fixed in this PR:
Clone::clone_fromimplementation. In this particular case we see this withVec<_>, which has a more efficient implementation..get().is_some()/.get().is_none()on map types, suggesting.contains()/.contains_key()instead. (In one case this identified a HashSet contains-then-insert, which is unnecessary due to howHashSet::insertworks.)