Fix/usdt dependency resolution failure#495
Closed
bnaecker wants to merge 5 commits into
Closed
Conversation
- Adds the Dropshot `usdt-probes` feature to every crate depending on both Dropshot and `slog-dtrace`. Leaving this feature out causes build failures when compiling packages individually, as the selected `usdt` feature actually includes inline assembly, but Dropshot does not include the right feature-selection crate attribute. This works when building the whole workspace, since all features are unioned. - Adds a `check` subcommand to `omicron-package`, that runs `cargo check` instead of `cargo build`. This is also run during CI now, to catch regressions here, at least for the crates that we package via `omicron-package`.
duplicated in the rust-toolchain.toml file.
Collaborator
Author
|
Foiled by the bots again. Closing. |
leftwo
pushed a commit
that referenced
this pull request
Aug 24, 2023
Updated sled-agent to no longer expect a propolis_client::instance_spec::VolumeConstructionRequest when it is now just a Crucible VolumeConstructionRequest. Changes in Crucible: eliminate spurious metadb-related syncs (#881) ACK the write after adding it to the work queue (#874) Use arc4random_buf or getrandom instead of ChaCha20Rng (#878) Fix crutest in README (#879) Show client_id in panic messages (#843) Reduce sqlite page cache size to 64KiB (#876) Only flush extents that might actually be dirty. (#875) Changes in Propolis: Clean up and restructure CQE handling in NVMe Improve error message when /dev/vmmctl not present (#506) new API endpoint for propolis-server to replace a crucible downstairs (#495) Update rustls-webpki for GHSA-fh2r-99q2-6mmg Add MemAsync block backend try reenabling PHD jobs (#484) Define versioned instance specs (#472) Update toml dependency to 0.7.x Add more USDT probes to NVMe emulation Add more to standalone-with-crucible (#490) Update propolis with new Crucible Volume change (#485) Minor polish to standalone-crucible doc Clean up bits for crucible in propolis-standalone doc iteration for crucible and propolis-standalone Skeleton docs for using propolis with crucible disks in isolation propolis-standalone: Update expected crucible opts (#488) Split up README content for server and standalone Add crucible config to propolis-standalone Use libstd-provided OnceCell equivalent Allow 64-vCPU instances on Helios (stlouis) Elide test (and doctest) steps where not required Clean up NVMe PRP parsing and add tests
leftwo
added a commit
that referenced
this pull request
Aug 24, 2023
Updated sled-agent to no longer expect a propolis_client::instance_spec::VolumeConstructionRequest when it is now just a Crucible VolumeConstructionRequest. Changes in Crucible: eliminate spurious metadb-related syncs (#881) ACK the write after adding it to the work queue (#874) Use arc4random_buf or getrandom instead of ChaCha20Rng (#878) Fix crutest in README (#879) Show client_id in panic messages (#843) Reduce sqlite page cache size to 64KiB (#876) Only flush extents that might actually be dirty. (#875) Changes in Propolis: Clean up and restructure CQE handling in NVMe Improve error message when /dev/vmmctl not present (#506) new API endpoint for propolis-server to replace a crucible downstairs (#495) Update rustls-webpki for GHSA-fh2r-99q2-6mmg Add MemAsync block backend try reenabling PHD jobs (#484) Define versioned instance specs (#472) Update toml dependency to 0.7.x Add more USDT probes to NVMe emulation Add more to standalone-with-crucible (#490) Update propolis with new Crucible Volume change (#485) Minor polish to standalone-crucible doc Clean up bits for crucible in propolis-standalone doc iteration for crucible and propolis-standalone Skeleton docs for using propolis with crucible disks in isolation propolis-standalone: Update expected crucible opts (#488) Split up README content for server and standalone Add crucible config to propolis-standalone Use libstd-provided OnceCell equivalent Allow 64-vCPU instances on Helios (stlouis) Elide test (and doctest) steps where not required Clean up NVMe PRP parsing and add tests Co-authored-by: Alan Hanson <alan@oxide.computer>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.