Improve "services PUT" API: Execute in parallel and allow zone teardown#3676
Merged
Conversation
smklein
added a commit
that referenced
this pull request
Jul 19, 2023
We have seen some behavior where, after failing to initialize services, the sled agent enters "split-brain" behavior, and on subsequent requests to initialize services, the sled agent is not aware of zones which it created itself. I believe this to be a possible cause: While integrating #3676 , I used `try_for_each_concurrent` to parallelize zone bringup. This is an operation which can potentially return early on cancellation, dropping all other ongoing zone initialization tasks. This PR mitigates this issue by preventing concurrent drop within service initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce the execution time of both RSS and sled boot a fair bit.
Comparing the moment of "omicron-package install" to "Nexus Handoff Complete", indicating that RSS has fully executed, on a 24 core, 64 GiB workstation running Helios:
Without this change: 9m8.171s
With this change: 3m58.622s
Before this PR
/servicesPUT API was purely additive. Removing anything from the set of zones to-be-run was unsupportedWith this PR
/servicesPUT API can now both add and remove zones.try_for_each_concurrentinvocation.Fixes #726